Re: merging HashJoin and Hash nodes

2019-10-31 Thread Andres Freund
Hi, On 2019-10-31 23:59:19 +0100, Tomas Vondra wrote: > On Tue, Oct 29, 2019 at 02:00:00PM +1300, Thomas Munro wrote: > > On Tue, Oct 29, 2019 at 12:15 PM Andres Freund wrote: > > > I've groused about this a few times, but to me it seems wrong that > > > HashJoin and Hash are separate nodes. They

Re: merging HashJoin and Hash nodes

2019-10-31 Thread Tomas Vondra
On Tue, Oct 29, 2019 at 02:00:00PM +1300, Thomas Munro wrote: On Tue, Oct 29, 2019 at 12:15 PM Andres Freund wrote: I've groused about this a few times, but to me it seems wrong that HashJoin and Hash are separate nodes. They're so tightly bound together that keeping them separate just doesn't

Re: merging HashJoin and Hash nodes

2019-10-28 Thread Thomas Munro
On Tue, Oct 29, 2019 at 12:15 PM Andres Freund wrote: > I've groused about this a few times, but to me it seems wrong that > HashJoin and Hash are separate nodes. They're so tightly bound together > that keeping them separate just doesn't architecturally makes sense, > imo. So I wrote a prototype.