Re: making pg_regress less noisy by removing boilerplate

2022-02-23 Thread Andrew Dunstan
On 2/22/22 17:06, Andres Freund wrote: >> What's involved in moving to require Unix socket support? > It works today (the CI scripts use it on windows for example). > > But it's awkward because make_temp_sockdir() defaults to /tmp/ if TMPDIR isn't > set. Which it is not by default on windows. The

Re: making pg_regress less noisy by removing boilerplate

2022-02-22 Thread Andres Freund
Hi, On 2022-02-22 08:55:23 -0500, Andrew Dunstan wrote: > I'm pretty sure all my Windows machines with buildfarm animals are > sufficiently modern except the XP machine, which only builds release 10 > nowadays. Cool. > What's involved in moving to require Unix socket support? It works today (t

Re: making pg_regress less noisy by removing boilerplate

2022-02-22 Thread Andrew Dunstan
On 2/21/22 12:31, Andres Freund wrote: > > We still have a few issues with ports conflicts on windows. We should really > consider just desupporting all windows versions without unix socket > support. But until then it seems useful to be able to figure out random > failures. > I'm pretty sure al

Re: making pg_regress less noisy by removing boilerplate

2022-02-21 Thread Andres Freund
Hi, On 2022-02-21 12:40:18 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2022-02-21 12:05:42 -0500, Tom Lane wrote: > >> except maybe the "running on port 51696 with PID 1156405" line (and I'm not > >> too wedded to that)? > > > We still have a few issues with ports conflicts on windows.

Re: making pg_regress less noisy by removing boilerplate

2022-02-21 Thread Tom Lane
Andres Freund writes: > On 2022-02-21 12:05:42 -0500, Tom Lane wrote: >> except maybe the "running on port 51696 with PID 1156405" line (and I'm not >> too wedded to that)? > We still have a few issues with ports conflicts on windows. We should really > consider just desupporting all windows vers

Re: making pg_regress less noisy by removing boilerplate

2022-02-21 Thread Andres Freund
Hi, On 2022-02-21 12:05:42 -0500, Tom Lane wrote: > Also, those steps typically run a lot faster than they did then > (both software speedups, and most people use better hardware). > We no longer need that output to reassure ourselves that progress > is being made. Indeed. > > It seems we could

Re: making pg_regress less noisy by removing boilerplate

2022-02-21 Thread Tom Lane
Andres Freund writes: > When running check-world, a good chunk of the output is just pg_regress > boilerplate. It doesn't matter when running tests individually or for tests > with a lot of individual tests like the main regression tests. But for lots of > the rest it is noisy. These days there ar

making pg_regress less noisy by removing boilerplate

2022-02-21 Thread Andres Freund
Hi, When running check-world, a good chunk of the output is just pg_regress boilerplate. It doesn't matter when running tests individually or for tests with a lot of individual tests like the main regression tests. But for lots of the rest it is noisy. These days there are many more regression tes