Re: make all ereport in gram.y print out relative location

2024-10-31 Thread Tom Lane
I wrote: > I can take a look at this, since it's basically a followup > to 774171c4f. Pushed with some cleanup and further hacking. regards, tom lane

Re: make all ereport in gram.y print out relative location

2024-10-31 Thread Tom Lane
jian he writes: > now changed to > static PartitionStrategy parsePartitionStrategy(char *strategy, int location, > core_yyscan_t yyscanner); I can take a look at this, since it's basically a followup to 774171c4f. regards, tom lane

Re: make all ereport in gram.y print out relative location

2024-10-29 Thread jian he
On Tue, Oct 29, 2024 at 10:49 PM Alvaro Herrera wrote: > > Why remove parsePartitionStrategy? You could just add an "int location" > parameter to it. > now changed to static PartitionStrategy parsePartitionStrategy(char *strategy, int location, core_yyscan_t yyscanner); From 2ec4466576778e42d393

Re: make all ereport in gram.y print out relative location

2024-10-29 Thread Alvaro Herrera
Why remove parsePartitionStrategy? You could just add an "int location" parameter to it. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Los cuentos de hadas no dan al niño su primera idea sobre los monstruos. Lo que le dan es su primera idea de la posible derro

make all ereport in gram.y print out relative location

2024-10-26 Thread jian he
hi. it would be better to make all ereport in gram.y print out the relative location. one benefit is quickly locating the error. in insertSelectOptions, some ereport won't call parser_errposition. To handle that I added a location to struct SelectLimit, so we can catch the location in the LIMIT/FE