Re: make additional use of optimized linear search routines

2022-09-21 Thread Nathan Bossart
On Thu, Sep 22, 2022 at 09:52:57AM +0900, Michael Paquier wrote: > On Wed, Sep 21, 2022 at 02:28:08PM +0800, Richard Guo wrote: >> I wonder if there are other code paths we can replace with the linear >> search routines. I tried to search for them but no luck. > > I have been looking at a couple o

Re: make additional use of optimized linear search routines

2022-09-21 Thread Michael Paquier
On Wed, Sep 21, 2022 at 02:28:08PM +0800, Richard Guo wrote: > I wonder if there are other code paths we can replace with the linear > search routines. I tried to search for them but no luck. I have been looking at a couple of simple patterns across the tree but no luck here either. Well, if some

Re: make additional use of optimized linear search routines

2022-09-20 Thread Richard Guo
On Wed, Sep 21, 2022 at 1:40 PM Michael Paquier wrote: > In short, switching those code paths to use the linear search routines > looks like a good thing in the long-term, so I would like to apply > this patch. If you have any comments or objections, please feel > free. Yeah, I agree that the

Re: make additional use of optimized linear search routines

2022-09-20 Thread Michael Paquier
On Sat, Sep 03, 2022 at 10:06:58AM +0900, Michael Paquier wrote: > Ohoh. This sounds like a good idea to me, close to what John has > applied lately. I'll take a closer look.. So, the two code paths patched here are rather isolated. The one in TransactionIdIsInProgress() requires an overflowed

Re: make additional use of optimized linear search routines

2022-09-02 Thread Michael Paquier
On Fri, Sep 02, 2022 at 03:16:11PM -0700, Nathan Bossart wrote: > On Fri, Sep 02, 2022 at 08:15:46PM +0800, Richard Guo wrote: >> +1 for the proposal. I did some simple grep work in the source codes but >> not too much outputs besides the two places addressed in your patches. > > Thanks for taking

Re: make additional use of optimized linear search routines

2022-09-02 Thread Nathan Bossart
On Fri, Sep 02, 2022 at 08:15:46PM +0800, Richard Guo wrote: > +1 for the proposal. I did some simple grep work in the source codes but > not too much outputs besides the two places addressed in your patches. Thanks for taking a look! > Here are some places I noticed that might be optimized with

Re: make additional use of optimized linear search routines

2022-09-02 Thread Richard Guo
On Fri, Sep 2, 2022 at 2:52 AM Nathan Bossart wrote: > I'm hoping to spend a bit more time looking for additional applications of > the pg_lfind*() suite of functions (and anywhere else where SIMD might be > useful, really). If you have any ideas in mind, I'm all ears. +1 for the proposal. I d

make additional use of optimized linear search routines

2022-09-01 Thread Nathan Bossart
Hi hackers, Now that we have some optimized linear search routines [0], I thought I'd quickly check whether we could use them elsewhere. To start, I took another look at a previously posted patch [1] and noticed two potentially useful applications of pg_lfind32(). The attached patches replace th