Re: logical streaming of xacts via test_decoding is broken

2020-11-17 Thread Amit Kapila
On Sun, Nov 15, 2020 at 11:34 AM Dilip Kumar wrote: > Pushed after minor changes. -- With Regards, Amit Kapila.

Re: logical streaming of xacts via test_decoding is broken

2020-11-14 Thread Dilip Kumar
On Fri, Nov 13, 2020 at 3:18 PM Amit Kapila wrote: > > On Thu, Nov 12, 2020 at 3:10 PM Dilip Kumar wrote: > > > > On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila wrote: > > > > > > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote: > > > > > 3. Can you please prepare a separate patch for test case

Re: logical streaming of xacts via test_decoding is broken

2020-11-13 Thread Amit Kapila
On Thu, Nov 12, 2020 at 3:10 PM Dilip Kumar wrote: > > On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila wrote: > > > > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote: > > > 3. Can you please prepare a separate patch for test case changes so > > that it would be easier to verify that it fails witho

Re: logical streaming of xacts via test_decoding is broken

2020-11-12 Thread Dilip Kumar
On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila wrote: > > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote: > > > > On Tue, Nov 10, 2020 at 11:18 AM Dilip Kumar wrote: > > > > > > On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila > > > wrote: > > > > For this case, users can use skip_empty_xacts = tr

Re: logical streaming of xacts via test_decoding is broken

2020-11-11 Thread Dilip Kumar
On Thu, 12 Nov 2020 at 11:37 AM, Amit Kapila wrote: > On Thu, Nov 12, 2020 at 11:29 AM Dilip Kumar > wrote: > > > > On Thu, Nov 12, 2020 at 8:45 AM Amit Kapila > wrote: > > > > > > > > Another thing I am thinking let's just not expose skip_empty_stream to > > > the user and consider the behavio

Re: logical streaming of xacts via test_decoding is broken

2020-11-11 Thread Amit Kapila
On Thu, Nov 12, 2020 at 11:29 AM Dilip Kumar wrote: > > On Thu, Nov 12, 2020 at 8:45 AM Amit Kapila wrote: > > > > > Another thing I am thinking let's just not expose skip_empty_stream to > > the user and consider the behavior based on the value of > > skip_empty_xacts. Internally, in the code, w

Re: logical streaming of xacts via test_decoding is broken

2020-11-11 Thread Dilip Kumar
On Thu, Nov 12, 2020 at 8:45 AM Amit Kapila wrote: > > On Wed, Nov 11, 2020 at 7:05 PM Dilip Kumar wrote: > > > > On Wed, Nov 11, 2020 at 6:59 PM Amit Kapila wrote: > > > > > > On Wed, Nov 11, 2020 at 10:00 AM Dilip Kumar > > > wrote: > > > > > > > > On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila

Re: logical streaming of xacts via test_decoding is broken

2020-11-11 Thread Amit Kapila
On Wed, Nov 11, 2020 at 7:05 PM Dilip Kumar wrote: > > On Wed, Nov 11, 2020 at 6:59 PM Amit Kapila wrote: > > > > On Wed, Nov 11, 2020 at 10:00 AM Dilip Kumar wrote: > > > > > > On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila > > > wrote: > > > > > > > > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar

Re: logical streaming of xacts via test_decoding is broken

2020-11-11 Thread Dilip Kumar
On Wed, Nov 11, 2020 at 6:59 PM Amit Kapila wrote: > > On Wed, Nov 11, 2020 at 10:00 AM Dilip Kumar wrote: > > > > On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila wrote: > > > > > > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote: > > > > > > > > > > You can probably add a comment as to why we ar

Re: logical streaming of xacts via test_decoding is broken

2020-11-11 Thread Amit Kapila
On Wed, Nov 11, 2020 at 10:00 AM Dilip Kumar wrote: > > On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila wrote: > > > > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote: > > > > > > > You can probably add a comment as to why we are disallowing this case. > > I thought of considering 'stream-changes'

Re: logical streaming of xacts via test_decoding is broken

2020-11-10 Thread Dilip Kumar
On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila wrote: > > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote: > > > > On Tue, Nov 10, 2020 at 11:18 AM Dilip Kumar wrote: > > > > > > On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila > > > wrote: > > > > For this case, users can use skip_empty_xacts = tr

Re: logical streaming of xacts via test_decoding is broken

2020-11-10 Thread Amit Kapila
On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote: > > On Tue, Nov 10, 2020 at 11:18 AM Dilip Kumar wrote: > > > > On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila > > wrote: > > > For this case, users can use skip_empty_xacts = true and > > > skip_empty_streams = false. I am just asking if the use

Re: logical streaming of xacts via test_decoding is broken

2020-11-10 Thread Dilip Kumar
On Tue, Nov 10, 2020 at 11:18 AM Dilip Kumar wrote: > > On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila wrote: > > > > On Tue, Nov 10, 2020 at 10:26 AM Dilip Kumar wrote: > > > > > > On Tue, Nov 10, 2020 at 8:14 AM Amit Kapila > > > wrote: > > > > > > > > On Mon, Nov 9, 2020 at 6:00 PM Dilip Kuma

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Dilip Kumar
On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila wrote: > > On Tue, Nov 10, 2020 at 10:26 AM Dilip Kumar wrote: > > > > On Tue, Nov 10, 2020 at 8:14 AM Amit Kapila wrote: > > > > > > On Mon, Nov 9, 2020 at 6:00 PM Dilip Kumar wrote: > > > > > > > > On Mon, Nov 9, 2020 at 5:37 PM Dilip Kumar > > >

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Amit Kapila
On Tue, Nov 10, 2020 at 10:26 AM Dilip Kumar wrote: > > On Tue, Nov 10, 2020 at 8:14 AM Amit Kapila wrote: > > > > On Mon, Nov 9, 2020 at 6:00 PM Dilip Kumar wrote: > > > > > > On Mon, Nov 9, 2020 at 5:37 PM Dilip Kumar wrote: > > > > > > > > On Mon, Nov 9, 2020 at 4:21 PM Amit Kapila > > > >

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Dilip Kumar
On Tue, Nov 10, 2020 at 8:14 AM Amit Kapila wrote: > > On Mon, Nov 9, 2020 at 6:00 PM Dilip Kumar wrote: > > > > On Mon, Nov 9, 2020 at 5:37 PM Dilip Kumar wrote: > > > > > > On Mon, Nov 9, 2020 at 4:21 PM Amit Kapila > > > wrote: > > > > > > The bigger question is do we want to give users an

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Amit Kapila
On Mon, Nov 9, 2020 at 6:00 PM Dilip Kumar wrote: > > On Mon, Nov 9, 2020 at 5:37 PM Dilip Kumar wrote: > > > > On Mon, Nov 9, 2020 at 4:21 PM Amit Kapila wrote: > > > > The bigger question is do we want to give users an option > > > for skip_empty_streams similar to skip_empty_xacts? I would a

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Dilip Kumar
On Mon, Nov 9, 2020 at 5:37 PM Dilip Kumar wrote: > > On Mon, Nov 9, 2020 at 4:21 PM Amit Kapila wrote: > > > > On Mon, Nov 9, 2020 at 3:01 PM Dilip Kumar wrote: > > > > > > On Mon, Nov 9, 2020 at 1:34 PM Dilip Kumar wrote: > > > > > > > > On Mon, Nov 9, 2020 at 11:31 AM Amit Kapila > > > > w

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Dilip Kumar
On Mon, Nov 9, 2020 at 4:21 PM Amit Kapila wrote: > > On Mon, Nov 9, 2020 at 3:01 PM Dilip Kumar wrote: > > > > On Mon, Nov 9, 2020 at 1:34 PM Dilip Kumar wrote: > > > > > > On Mon, Nov 9, 2020 at 11:31 AM Amit Kapila > > > wrote: > > > > > > > > On Mon, Nov 9, 2020 at 11:21 AM Dilip Kumar >

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Amit Kapila
On Mon, Nov 9, 2020 at 3:01 PM Dilip Kumar wrote: > > On Mon, Nov 9, 2020 at 1:34 PM Dilip Kumar wrote: > > > > On Mon, Nov 9, 2020 at 11:31 AM Amit Kapila wrote: > > > > > > On Mon, Nov 9, 2020 at 11:21 AM Dilip Kumar wrote: > > > > > > > > On Mon, Nov 9, 2020 at 11:04 AM Dilip Kumar > > > >

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Dilip Kumar
On Mon, Nov 9, 2020 at 1:34 PM Dilip Kumar wrote: > > On Mon, Nov 9, 2020 at 11:31 AM Amit Kapila wrote: > > > > On Mon, Nov 9, 2020 at 11:21 AM Dilip Kumar wrote: > > > > > > On Mon, Nov 9, 2020 at 11:04 AM Dilip Kumar wrote: > > > > > > > > On Mon, Nov 9, 2020 at 11:00 AM Amit Kapila > > >

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Dilip Kumar
On Mon, Nov 9, 2020 at 11:31 AM Amit Kapila wrote: > > On Mon, Nov 9, 2020 at 11:21 AM Dilip Kumar wrote: > > > > On Mon, Nov 9, 2020 at 11:04 AM Dilip Kumar wrote: > > > > > > On Mon, Nov 9, 2020 at 11:00 AM Amit Kapila > > > wrote: > > > > > > > > Michael reported a BF failure [1] related to

Re: logical streaming of xacts via test_decoding is broken

2020-11-08 Thread Amit Kapila
On Mon, Nov 9, 2020 at 11:21 AM Dilip Kumar wrote: > > On Mon, Nov 9, 2020 at 11:04 AM Dilip Kumar wrote: > > > > On Mon, Nov 9, 2020 at 11:00 AM Amit Kapila wrote: > > > > > > Michael reported a BF failure [1] related to one of the logical > > > streaming test case and I've analyzed the issue.

Re: logical streaming of xacts via test_decoding is broken

2020-11-08 Thread Dilip Kumar
On Mon, Nov 9, 2020 at 11:04 AM Dilip Kumar wrote: > > On Mon, Nov 9, 2020 at 11:00 AM Amit Kapila wrote: > > > > Michael reported a BF failure [1] related to one of the logical > > streaming test case and I've analyzed the issue. As responded on > > pgsql-committers [2], the issue here is that t

Re: logical streaming of xacts via test_decoding is broken

2020-11-08 Thread Dilip Kumar
On Mon, Nov 9, 2020 at 11:00 AM Amit Kapila wrote: > > Michael reported a BF failure [1] related to one of the logical > streaming test case and I've analyzed the issue. As responded on > pgsql-committers [2], the issue here is that the streaming > transactions can be interleaved and because we ar

logical streaming of xacts via test_decoding is broken

2020-11-08 Thread Amit Kapila
Michael reported a BF failure [1] related to one of the logical streaming test case and I've analyzed the issue. As responded on pgsql-committers [2], the issue here is that the streaming transactions can be interleaved and because we are maintaining whether xact_wrote_changes at the LogicalDecodin