Re: list_free in addRangeTableEntryForJoin

2024-06-10 Thread Tom Lane
Ilia Evdokimov writes: > I have identified a potential memory leak in the > `addRangeTableEntryForJoin()` function. The second parameter of > `addRangeTableEntryForJoin()`, `colnames`, is a `List*` that is > concatenated with another `List*`, `eref->colnames`, using > `list_concat()`. We need

Re: list_free in addRangeTableEntryForJoin

2024-06-10 Thread Ranier Vilela
Em seg., 10 de jun. de 2024 às 10:45, Ilia Evdokimov < ilya.evdoki...@tantorlabs.com> escreveu: > >Now you need to analyze whether the memory in question is not managed > by a Context > I've already analyzed. Let's explain details: > > > 1. analyze.c > 1718: List* targetnames; > 1815: targetnames

Re: list_free in addRangeTableEntryForJoin

2024-06-10 Thread Ilia Evdokimov
>Now you need to analyze whether the memory in question is not managed by a Context I've already analyzed. Let's explain details: 1. analyze.c 1718: List* targetnames; 1815: targetnames = NIL; 1848: targetnames = lappend(targetnames, makeString(colName)); 1871: addRangeTableEntryForJoin(...); =

Re: list_free in addRangeTableEntryForJoin

2024-06-10 Thread Ranier Vilela
Em seg., 10 de jun. de 2024 às 09:11, Ilia Evdokimov < ilya.evdoki...@tantorlabs.com> escreveu: > >But callers of addRangeTableEntryForJoin(), expects to handle a list > or NIL, if we free the memory > I've thoroughly reviewed all callers of the > `addRangeTableEntryForJoin()` function and confir

Re: list_free in addRangeTableEntryForJoin

2024-06-10 Thread Ilia Evdokimov
>But callers of addRangeTableEntryForJoin(), expects to handle a list or NIL, if we free the memory I've thoroughly reviewed all callers of the `addRangeTableEntryForJoin()` function and confirmed that the list is not used after this function is called. Since `addRangeTableEntryForJoin()` is th

Re: list_free in addRangeTableEntryForJoin

2024-06-10 Thread Ranier Vilela
Em seg., 10 de jun. de 2024 às 07:35, Ilia Evdokimov < ilya.evdoki...@tantorlabs.com> escreveu: > Hi Hackers > > I have identified a potential memory leak in the > `addRangeTableEntryForJoin()` function. The second parameter of > `addRangeTableEntryForJoin()`, `colnames`, is a `List*` that is > co

list_free in addRangeTableEntryForJoin

2024-06-10 Thread Ilia Evdokimov
Hi Hackers I have identified a potential memory leak in the `addRangeTableEntryForJoin()` function. The second parameter of `addRangeTableEntryForJoin()`, `colnames`, is a `List*` that is concatenated with another `List*`, `eref->colnames`, using `list_concat()`. We need to pass only the last