Re: list of TransactionIds

2022-10-20 Thread Alvaro Herrera
Hello On 2022-Oct-20, houzj.f...@fujitsu.com wrote: > While trying to use the newly introduced list_member_xid(), I noticed that it > internally use lfirst_oid instead of lfirst_xid. It works ok for now. Just in > case we change xid to 64 bits in the future, I think we’d better use > lfirst_xid

RE: list of TransactionIds

2022-10-20 Thread houzj.f...@fujitsu.com
On Monday, July 4, 2022 9:27 PM Alvaro Herrera wrote: Hi, > > Pushed now, to master only. Thanks for introducing these APIs! While trying to use the newly introduced list_member_xid(), I noticed that it internally use lfirst_oid instead of lfirst_xid. It works ok for now. Just in case we chan

Re: list of TransactionIds

2022-07-04 Thread Alvaro Herrera
On 2022-May-16, Amit Kapila wrote: > On Sun, May 15, 2022 at 5:05 PM Alvaro Herrera > wrote: > > I hesitate to add this the day just before beta. This is already in > > pg14, so maybe it's not a big deal if pg15 remains the same for the time > > being. Or we can change it for beta2. Or we co

Re: list of TransactionIds

2022-05-15 Thread Michael Paquier
On Mon, May 16, 2022 at 07:58:37AM +0530, Amit Kapila wrote: > I prefer to do this for pg16 unless we see some bug due to this. Agreed. This does not seem worth taking any risk with after beta1, and v14 got released this way. -- Michael signature.asc Description: PGP signature

Re: list of TransactionIds

2022-05-15 Thread Amit Kapila
On Sun, May 15, 2022 at 5:05 PM Alvaro Herrera wrote: > > On 2022-May-14, Amit Kapila wrote: > > > On Sat, May 14, 2022 at 1:57 AM Alvaro Herrera > > wrote: > > > > > > We didn't have any use of TransactionId as members of List, until > > > RelationSyncEntry->streamed_txns was introduced (464824

Re: list of TransactionIds

2022-05-15 Thread Alvaro Herrera
On 2022-May-14, Amit Kapila wrote: > On Sat, May 14, 2022 at 1:57 AM Alvaro Herrera > wrote: > > > > We didn't have any use of TransactionId as members of List, until > > RelationSyncEntry->streamed_txns was introduced (464824323e57, pg14). > > It's currently implemented as a list of int. This

Re: list of TransactionIds

2022-05-14 Thread Amit Kapila
On Sat, May 14, 2022 at 1:57 AM Alvaro Herrera wrote: > > We didn't have any use of TransactionId as members of List, until > RelationSyncEntry->streamed_txns was introduced (464824323e57, pg14). > It's currently implemented as a list of int. This is not wrong at > present, but it may soon be, an

list of TransactionIds

2022-05-13 Thread Alvaro Herrera
We didn't have any use of TransactionId as members of List, until RelationSyncEntry->streamed_txns was introduced (464824323e57, pg14). It's currently implemented as a list of int. This is not wrong at present, but it may soon be, and I'm sure it rubs some people the wrong way. But is the rubbing