On Fri, Sep 27, 2019 at 5:41 AM Jeevan Ladhe
wrote:
> I have reviewed your patch, and it seems correctly implementing the
> actions per subtransactions using stack. Atleast I could not find
> any flaw with your implementation here.
Thanks for the review. Based on this and other positive comments
Correction -
On Fri, Sep 27, 2019 at 3:11 PM Jeevan Ladhe
wrote:
> I ran your testcase and on my VM I get numbers like 3593.801 ms
> without patch and 3593.801 with the patch, average of 5 runs each.
> The runs were quite consistent.
>
3593.801 ms without patch and 3213.809 with the patch,
app
>
> I did not read the patch but run the same case what you have given and
> I can see the similar improvement with the patch.
> With the patch 8832.988, without the patch 10252.701ms (median of three
> reading)
>
Possibly you had debug symbols enabled? With debug symbols enabled
I also get about
Hi Robert,
Generally, a subsystem can avoid needing a callback at subtransaction
> start (or transaction start) by detecting new levels of
> subtransactions at time of use.
Yes I agree with this argument.
> A typical practice is to maintain a
> stack which has entries only for those transactio
At Thu, 12 Sep 2019 09:44:49 +0530, Dilip Kumar wrote
in
> On Wed, Sep 11, 2019 at 6:22 PM Robert Haas wrote:
> > trivial subtransactions. I used this test case:
> >
> > \timing
> > do $$begin for i in 1 .. 1000 loop begin null; exception when
> > others then null; end; end loop; end;$$;
>
On Wed, Sep 11, 2019 at 6:22 PM Robert Haas wrote:
>
> There are only four subsystems which require a callback at the
> beginning of each subtransaction: the relevant functions are
> AtSubStart_Memory, AtSubStart_ResourceOwner, AtSubStart_Notify, and
> AfterTriggerBeginSubXact. The AtSubStart_Memo
There are only four subsystems which require a callback at the
beginning of each subtransaction: the relevant functions are
AtSubStart_Memory, AtSubStart_ResourceOwner, AtSubStart_Notify, and
AfterTriggerBeginSubXact. The AtSubStart_Memory and
AtSubStart_ResourceOwner callbacks seem relatively unob
