Re: ldapi support

2018-02-12 Thread Peter Eisentraut
On 2/10/18 19:46, Michael Paquier wrote: > On Fri, Feb 09, 2018 at 08:44:38PM -0500, Peter Eisentraut wrote: >> Hmm. I think the ldap test suite should be changed to use >> $node->restart instead of $node->reload, so we can be sure that the >> various pg_hba.conf lines are actually accepted. It a

Re: ldapi support

2018-02-10 Thread Michael Paquier
On Fri, Feb 09, 2018 at 08:44:38PM -0500, Peter Eisentraut wrote: > Hmm. I think the ldap test suite should be changed to use > $node->restart instead of $node->reload, so we can be sure that the > various pg_hba.conf lines are actually accepted. It appears that doing > so wouldn't impact the run

Re: ldapi support

2018-02-09 Thread Peter Eisentraut
On 2/8/18 22:56, Thomas Munro wrote: > The test doesn't actually succeed in reloading the pg_hba.conf > file though: > > 2018-02-09 16:41:15.886 NZDT [24472] LOG: received SIGHUP, reloading > configuration files > 2018-02-09 16:41:15.893 NZDT [24472] LOG: unsupported LDAP URL scheme: ldapi > 201

Re: ldapi support

2018-02-08 Thread Thomas Munro
On Fri, Feb 9, 2018 at 4:05 PM, Peter Eisentraut wrote: > After the LDAP code was switched to use ldap_initialize() as part of the > ldaps support, ldapi (LDAP over Unix-domain sockets) also works. I > noticed an old bug report (#13625) that asked for it. So I suggest this > patch to document th

ldapi support

2018-02-08 Thread Peter Eisentraut
After the LDAP code was switched to use ldap_initialize() as part of the ldaps support, ldapi (LDAP over Unix-domain sockets) also works. I noticed an old bug report (#13625) that asked for it. So I suggest this patch to document this and add some tests. One flaw is that this only works when usi