Re: killing perl2host

On Sun, Feb 20, 2022 at 10:51 AM Andrew Dunstan wrote: > On 2/19/22 16:34, Andres Freund wrote: > >> The first > >> removes perl2host completely and adjusts all the places that use it. > >> The second removes almost all the remaining msys special processing in > >> TAP tests. Very nice improveme

Re: killing perl2host

On 2022-02-19 16:51:18 -0500, Andrew Dunstan wrote: > I will backpatch it. That'll be a bit of fun given how much the TAP > tests change, but I think it's worth it. Agreed. And thanks.

Re: killing perl2host

On 2/19/22 16:34, Andres Freund wrote: > Hi, > > On 2022-02-19 13:04:05 -0500, Andrew Dunstan wrote: >> OK, nothing broke, so here are two more invasive patches. > Great! > > >> The first >> removes perl2host completely and adjusts  all the places that use it. >> The second removes almost all the

Re: killing perl2host

Hi, On 2022-02-19 13:04:05 -0500, Andrew Dunstan wrote: > OK, nothing broke, so here are two more invasive patches. Great! > The first > removes perl2host completely and adjusts  all the places that use it. > The second removes almost all the remaining msys special processing in > TAP tests. H

Re: killing perl2host

On 2/19/22 13:04, Andrew Dunstan wrote: > On 2/16/22 15:46, Andrew Dunstan wrote: >> Largely following a recipe from Andres, I have migrated buildfarm >> animals fairywren and jacana to a setup that shouldn't need (and in fact >> won't be able to use) PostgreSQL::Test:Utils::perl2host(). AFAICT t

Re: killing perl2host

On 2/16/22 15:46, Andrew Dunstan wrote: > Largely following a recipe from Andres, I have migrated buildfarm > animals fairywren and jacana to a setup that shouldn't need (and in fact > won't be able to use) PostgreSQL::Test:Utils::perl2host(). AFAICT these > two are the only buildfarm animals that

Re: killing perl2host

On 2/18/22 17:34, Andrew Dunstan wrote: > On 2/17/22 12:12, Andres Freund wrote: >> Hi, >> >> On 2022-02-17 09:20:56 -0500, Andrew Dunstan wrote: >>> I don't think we have or have ever had a buildfarm animal targeting >>> msys. In general I think of msys as a build environment to create native >>

Re: killing perl2host

On 2/17/22 12:12, Andres Freund wrote: > Hi, > > On 2022-02-17 09:20:56 -0500, Andrew Dunstan wrote: >> I don't think we have or have ever had a buildfarm animal targeting >> msys. In general I think of msys as a build environment to create native >> binaries. But if we want to support targeting

Re: killing perl2host

On 2/17/22 15:46, Andres Freund wrote: > On 2022-02-17 15:23:36 -0500, Andrew Dunstan wrote: >> Very well. I think the easiest way will be to stash $host_os in the >> environment and let the script pick it up similarly to what I suggested >> with MSYSTEM. > WFM. OK, here's a patch. cheers an

Re: killing perl2host

On 2022-02-17 15:23:36 -0500, Andrew Dunstan wrote: > Very well. I think the easiest way will be to stash $host_os in the > environment and let the script pick it up similarly to what I suggested > with MSYSTEM. WFM.

Re: killing perl2host

On 2/17/22 15:09, Andres Freund wrote: > Hi, > > On 2022-02-17 14:40:01 -0500, Andrew Dunstan wrote: >> Sure, that could be done, but what's the issue? Msys2 normally defines >> MSYSTEM for you - see /etc/msystem which is sourced by /etc/profile. > It seems not a great idea to me to use different

Re: killing perl2host

Hi, On 2022-02-17 14:40:01 -0500, Andrew Dunstan wrote: > Sure, that could be done, but what's the issue? Msys2 normally defines > MSYSTEM for you - see /etc/msystem which is sourced by /etc/profile. It seems not a great idea to me to use different sources of truth about build target. And I think

Re: killing perl2host

On 2/17/22 13:10, Andres Freund wrote: > On 2022-02-17 13:08:01 -0500, Andrew Dunstan wrote: perhaps something like:     my $msystem = $ENV{MSYSTEM} || 'undef';     die "incompatible perl" if $Config{osname} eq 'msys' && $msystem ne 'MSYS'; >>> Why tests MSYSTEM

Re: killing perl2host

On 2022-02-17 13:08:01 -0500, Andrew Dunstan wrote: > >> perhaps something like: > >> > >> > >>     my $msystem = $ENV{MSYSTEM} || 'undef'; > >> > >>     die "incompatible perl" if $Config{osname} eq 'msys' && $msystem ne > >> 'MSYS'; > > Why tests MSYSTEM instead of $host_os? > Is that available

Re: killing perl2host

On 2/17/22 12:12, Andres Freund wrote: > Hi, > > On 2022-02-17 09:20:56 -0500, Andrew Dunstan wrote: >> I don't think we have or have ever had a buildfarm animal targeting >> msys. In general I think of msys as a build environment to create native >> binaries. But if we want to support targeting

Re: killing perl2host

Hi, On 2022-02-17 09:20:56 -0500, Andrew Dunstan wrote: > I don't think we have or have ever had a buildfarm animal targeting > msys. In general I think of msys as a build environment to create native > binaries. But if we want to support targeting msys we should have an > animal doing that. It's

Re: killing perl2host

On 2/16/22 21:17, Andres Freund wrote: > Hi, > > On 2022-02-16 14:42:30 -0800, Andres Freund wrote: >> On February 16, 2022 1:10:35 PM PST, Andrew Dunstan >> wrote: >>> So something like this in Utils.pm: >>> >>> >>> die "Msys targeted perl is unsupported for running TAP tests" if >>> $Config{o

Re: killing perl2host

Hi, On 2022-02-16 14:42:30 -0800, Andres Freund wrote: > On February 16, 2022 1:10:35 PM PST, Andrew Dunstan > wrote: > >So something like this in Utils.pm: > > > > > >die "Msys targeted perl is unsupported for running TAP tests" if > >$Config{osname}eq 'msys'; > > I don't think we should rejec

Re: killing perl2host

Hi, On February 16, 2022 1:10:35 PM PST, Andrew Dunstan wrote: > >On 2/16/22 16:01, Andres Freund wrote: >> Hi, >> >> On 2022-02-16 15:46:28 -0500, Andrew Dunstan wrote: >>> I suggest that we apply this patch: >> +1 >> >>> and if nothing breaks in a few days I will set about a more thorough >>>

Re: killing perl2host

On 2/16/22 16:01, Andres Freund wrote: > Hi, > > On 2022-02-16 15:46:28 -0500, Andrew Dunstan wrote: >> I suggest that we apply this patch: > +1 > >> and if nothing breaks in a few days I will set about a more thorough >> removal of perl2host() and adjusting everywhere it's called, and we can >>

Re: killing perl2host

Hi, On 2022-02-16 15:46:28 -0500, Andrew Dunstan wrote: > I suggest that we apply this patch: +1 > and if nothing breaks in a few days I will set about a more thorough > removal of perl2host() and adjusting everywhere it's called, and we can > forget that the whole sorry mess ever happened :-)

killing perl2host

Largely following a recipe from Andres, I have migrated buildfarm animals fairywren and jacana to a setup that shouldn't need (and in fact won't be able to use) PostgreSQL::Test:Utils::perl2host(). AFAICT these two are the only buildfarm animals that run TAP tests under msys. See discussion at