Re: initdb caching during tests

2023-12-08 Thread Daniel Gustafsson
> On 7 Dec 2023, at 15:27, Matthias van de Meent > wrote: > Then that'd be the attached patch, which also includes --auth instead > of -A, for the same reason as -N vs --no-sync Applied to master, thanks! -- Daniel Gustafsson

Re: initdb caching during tests

2023-12-07 Thread Matthias van de Meent
On Thu, 7 Dec 2023 at 15:06, Daniel Gustafsson wrote: > > > On 7 Dec 2023, at 14:50, Matthias van de Meent > > wrote: > > > Attached a patch that fixes this for both make and meson, by adding > > --no-clean to the initdb template. > > Makes sense. While in there I think we should rename -N to t

Re: initdb caching during tests

2023-12-07 Thread Daniel Gustafsson
> On 7 Dec 2023, at 14:50, Matthias van de Meent > wrote: > Attached a patch that fixes this for both make and meson, by adding > --no-clean to the initdb template. Makes sense. While in there I think we should rename -N to the long optoin --no-sync to make it easier to grep for and make the b

Re: initdb caching during tests

2023-12-07 Thread Matthias van de Meent
On Fri, 25 Aug 2023 at 00:16, Andres Freund wrote: > > Hi, > > On 2023-08-23 10:10:31 +0200, Daniel Gustafsson wrote: > > > On 23 Aug 2023, at 03:17, Andres Freund wrote: > > > On 2023-08-22 23:47:24 +0200, Daniel Gustafsson wrote: > > > > >> My only small gripe is that I keep thinking about temp

Re: initdb caching during tests

2023-08-25 Thread Nathan Bossart
On Thu, Aug 24, 2023 at 03:10:00PM -0700, Andres Freund wrote: > Cool. Pushed that way. I just noticed the tests running about 30% faster on my machine due to this. Thanks! -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: initdb caching during tests

2023-08-25 Thread Andres Freund
Hi, On 2023-08-25 09:00:24 +0200, Daniel Gustafsson wrote: > > On 25 Aug 2023, at 07:50, Thomas Munro wrote: > > > > On Fri, Aug 25, 2023 at 10:10 AM Andres Freund wrote: > >> Let's see what the buildfarm says - it's not inconceivable that it'll show > >> some issues. > > > > Apparently Solari

Re: initdb caching during tests

2023-08-25 Thread Daniel Gustafsson
> On 25 Aug 2023, at 07:50, Thomas Munro wrote: > > On Fri, Aug 25, 2023 at 10:10 AM Andres Freund wrote: >> Let's see what the buildfarm says - it's not inconceivable that it'll show >> some issues. > > Apparently Solaris doesn't like "cp -a", per animal "margay". I think > "cp -RPp" should b

Re: initdb caching during tests

2023-08-24 Thread Thomas Munro
On Fri, Aug 25, 2023 at 10:10 AM Andres Freund wrote: > Let's see what the buildfarm says - it's not inconceivable that it'll show > some issues. Apparently Solaris doesn't like "cp -a", per animal "margay". I think "cp -RPp" should be enough everywhere? https://docs.oracle.com/cd/E88353_01/htm

Re: initdb caching during tests

2023-08-24 Thread Andres Freund
Hi, On 2023-08-23 10:10:31 +0200, Daniel Gustafsson wrote: > > On 23 Aug 2023, at 03:17, Andres Freund wrote: > > On 2023-08-22 23:47:24 +0200, Daniel Gustafsson wrote: > > >> My only small gripe is that I keep thinking about template databases for > >> CREATE > >> DATABASE when reading the err

Re: initdb caching during tests

2023-08-23 Thread Daniel Gustafsson
> On 23 Aug 2023, at 03:17, Andres Freund wrote: > On 2023-08-22 23:47:24 +0200, Daniel Gustafsson wrote: >> My only small gripe is that I keep thinking about template databases for >> CREATE >> DATABASE when reading the error messages in this patch, which is clearly not >> related to what this

Re: initdb caching during tests

2023-08-22 Thread Andres Freund
Hi, On 2023-08-22 23:47:24 +0200, Daniel Gustafsson wrote: > I had a look at this today and have been running a lot of tests with it > without > finding anything that breaks. Thanks! > The duplicated code is unfortunate, but after playing around with some > options I agree that it's likely the

Re: initdb caching during tests

2023-08-22 Thread Daniel Gustafsson
> On 5 Aug 2023, at 21:56, Andres Freund wrote: > We have some issues with CI on macos and windows being too expensive (more on > that soon in a separate email), which reminded me of this thread (with > original title: [1]) > > I've attached a somewhat cleaned up version of the patch to cache in

Re: initdb caching during tests

2023-08-05 Thread Andres Freund
Hi, On 2023-08-05 16:58:38 -0400, Tom Lane wrote: > Andres Freund writes: > > Times for running all tests under meson, on my workstation (20 cores / 40 > > threads): > > > cassert build -O2: > > > Before: > > real0m44.638s > > user7m58.780s > > sys 2m48.773s > > > After: > > re

Re: initdb caching during tests

2023-08-05 Thread Tom Lane
Andres Freund writes: > Times for running all tests under meson, on my workstation (20 cores / 40 > threads): > cassert build -O2: > Before: > real 0m44.638s > user 7m58.780s > sys 2m48.773s > After: > real 0m38.938s > user 2m37.615s > sys 2m0.570s Impressive results. Even though your

initdb caching during tests

2023-08-05 Thread Andres Freund
Hi, We have some issues with CI on macos and windows being too expensive (more on that soon in a separate email), which reminded me of this thread (with original title: [1]) I've attached a somewhat cleaned up version of the patch to cache initdb across runs. The results are still fairly impress