Re: incorrect error message, while dropping PROCEDURE

2017-12-14 Thread Rushabh Lathia
On Fri, Dec 15, 2017 at 3:32 AM, Michael Paquier wrote: > On Fri, Dec 15, 2017 at 12:18 AM, Peter Eisentraut > wrote: > > On 12/13/17 23:31, Rushabh Lathia wrote: > >> PFA patch, where introduced new AclObjectKind (ACL_KIND_PROCEDURE), > >> msg for the new AclObjectKind, and passed it through at

Re: incorrect error message, while dropping PROCEDURE

2017-12-14 Thread Michael Paquier
On Fri, Dec 15, 2017 at 12:18 AM, Peter Eisentraut wrote: > On 12/13/17 23:31, Rushabh Lathia wrote: >> PFA patch, where introduced new AclObjectKind (ACL_KIND_PROCEDURE), >> msg for the new AclObjectKind, and passed it through at >> appropriate places. > > Yeah, that's a way to do it, but having

Re: incorrect error message, while dropping PROCEDURE

2017-12-14 Thread Peter Eisentraut
On 12/13/17 23:31, Rushabh Lathia wrote: > Currently if some one try to drop the PROCEDURE and > it don't have privilege or it's not an owner, than error message > still indicate object as FUNCTION. Yes, that is actually something that is fixed by the patches proposed in the thread "replace GrantO

incorrect error message, while dropping PROCEDURE

2017-12-13 Thread Rushabh Lathia
Hi, Currently if some one try to drop the PROCEDURE and it don't have privilege or it's not an owner, than error message still indicate object as FUNCTION. Example: postgres@37737=#drop procedure pro; ERROR: must be owner of function pro This doesn't look correct specially that now we have sep