Re: implicit casts from void*

2025-07-01 Thread Tom Lane
John Naylor writes: > On Tue, Jul 1, 2025 at 10:36 AM Tom Lane wrote: >> Hmpfh. No objection to your patch, but I wonder why >> "headerscheck --cplusplus" didn't find this? Can we get it >> to do so? > Good question, and it turns out it catches it just fine, but you have > to configure with CP

Re: implicit casts from void*

2025-06-30 Thread John Naylor
On Tue, Jul 1, 2025 at 10:36 AM Tom Lane wrote: > > John Naylor writes: > > I received on off-list report that commit e2809e3a101 causes an error > > when building an extension written in C++, since $subject is in a > > header file. The fix is simply to add an explicit cast, so I plan to > > push

Re: implicit casts from void*

2025-06-30 Thread Tom Lane
John Naylor writes: > I received on off-list report that commit e2809e3a101 causes an error > when building an extension written in C++, since $subject is in a > header file. The fix is simply to add an explicit cast, so I plan to > push the attached soon. Hmpfh. No objection to your patch, but

implicit casts from void*

2025-06-30 Thread John Naylor
I received on off-list report that commit e2809e3a101 causes an error when building an extension written in C++, since $subject is in a header file. The fix is simply to add an explicit cast, so I plan to push the attached soon. Bikeshedding: We could additionally change the pg_crc*.c files to mak