Re: hostorder and failover_timeout for libpq

2019-02-03 Thread Andres Freund
Hi, On 2018-11-29 17:23:11 +0100, Dmitry Dolgov wrote: > > On Mon, Oct 1, 2018 at 9:10 AM Michael Paquier wrote: > > > > By the way, I can see that the latest patch available does not apply at > > tries to juggle with multiple concepts. I can see at least two of them: > > failover_timeout and ho

Re: hostorder and failover_timeout for libpq

2019-01-14 Thread Tom Lane
Michael Paquier writes: > On Wed, Sep 19, 2018 at 02:26:53PM +0200, Ildar Musin wrote: >> At this point I'd like to ask community what in your opinion would be the >> best course of action and whether this feature should be implemented within >> libpq at all? Because from my POV there are factors

Re: hostorder and failover_timeout for libpq

2018-11-29 Thread Dmitry Dolgov
> On Mon, Oct 1, 2018 at 9:10 AM Michael Paquier wrote: > > By the way, I can see that the latest patch available does not apply at > tries to juggle with multiple concepts. I can see at least two of them: > failover_timeout and hostorder. You should split things. I have moved > the patch to ne

Re: hostorder and failover_timeout for libpq

2018-10-01 Thread Michael Paquier
On Wed, Sep 19, 2018 at 02:26:53PM +0200, Ildar Musin wrote: > Another approach would be to leave `pg_conn->connhost` as it is now (i.e. > not to create global addresses array) and just apply random permutations to > it if `hostorder=random` is specified. And probably apply permutations to > addres

Re: hostorder and failover_timeout for libpq

2018-09-19 Thread Ildar Musin
Hello Surafel, On Fri, Sep 14, 2018 at 2:03 PM Surafel Temesgen wrote: > Hey , > Here are a few comment. > + xreflabel="failover_timeout"> > Here's a typo: ="libpq-connect-falover-timeout" > + {"failover_timeout", NULL, NULL, NULL, > + "Failover Timeout", "", 10, > Word

Re: hostorder and failover_timeout for libpq

2018-09-14 Thread Surafel Temesgen
Hey , Here are a few comment. + Here's a typo: ="libpq-connect-falover-timeout" + {"failover_timeout", NULL, NULL, NULL, + "Failover Timeout", "", 10, Word is separated by hyphen in internalPQconninfoOption lable as a surrounding code +If the value is random, the ho

RE: hostorder and failover_timeout for libpq

2018-07-10 Thread Iwata, Aya
Hello Ildar, I have a question about failover_timeout parameter. Which would be better: implementing the parameter to retry at waiting time or controlling the connection retry on the application side? Also, I have no idea if the amount of random access by hostorder parameter will have a good ef

hostorder and failover_timeout for libpq

2018-04-18 Thread Ildar Musin
Hello hackers, Couple of years ago Victor Wagner presented a patch [1] that introduced multiple hosts capability and also hostorder and failover_timeout parameters for libpq. Subsequently multi-host feature was reimplemented by Robert Haas and committed. Later target_session_attrs parameter wa