Re: handling of heap rewrites in logical decoding

2018-03-21 Thread Craig Ringer
On 21 March 2018 at 21:20, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/21/18 03:08, Craig Ringer wrote: > > Why was relrewrite / Anum_pg_class_relrewrite inserted at position 28, > > not appended to pg_class? > > > > I don't see how it'd cause any harm, I'm just curious abou

Re: handling of heap rewrites in logical decoding

2018-03-21 Thread Peter Eisentraut
On 3/21/18 03:08, Craig Ringer wrote: > Why was relrewrite / Anum_pg_class_relrewrite inserted at position 28, > not appended to pg_class? > > I don't see how it'd cause any harm, I'm just curious about the rationale. Adding it at the end would not be appropriate, since those are variable-length

Re: handling of heap rewrites in logical decoding

2018-03-21 Thread Craig Ringer
On 16 March 2018 at 10:54, Craig Ringer wrote: > On 16 March 2018 at 08:51, Peter Eisentraut com> wrote: > >> On 2/28/18 13:52, Peter Eisentraut wrote:> Second version, which uses an >> OID. I added another field to the output> plugin options (next to the >> output_type), to indicate whether th

Re: handling of heap rewrites in logical decoding

2018-03-15 Thread Craig Ringer
On 16 March 2018 at 08:51, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2/28/18 13:52, Peter Eisentraut wrote:> Second version, which uses an > OID. I added another field to the output> plugin options (next to the > output_type), to indicate whether the plugin> wants to receiv

Re: handling of heap rewrites in logical decoding

2018-03-15 Thread Peter Eisentraut
On 2/28/18 13:52, Peter Eisentraut wrote:> Second version, which uses an OID. I added another field to the output> plugin options (next to the output_type), to indicate whether the plugin> wants to receive these changes. I added some test cases to> test_decoding to show how it works either way.

Re: handling of heap rewrites in logical decoding

2018-02-28 Thread Peter Eisentraut
On 2/25/18 07:27, Craig Ringer wrote: > I'm pretty sure we _will_ want the ability to decode and stream rewrite > contents for non-IMMUTABLE table rewrites. > > Filtering out by default is OK by me, but I think making it impossible > to decode is a mistake. So I'm all for the oid option and had wr

Re: handling of heap rewrites in logical decoding

2018-02-25 Thread Craig Ringer
On 25 February 2018 at 09:57, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > A heap rewrite during a DDL command publishes changes for relations > named like pg_temp_%u, which are not real tables, and this breaks > replication systems that are not aware of that. We have a hack in t

handling of heap rewrites in logical decoding

2018-02-24 Thread Peter Eisentraut
A heap rewrite during a DDL command publishes changes for relations named like pg_temp_%u, which are not real tables, and this breaks replication systems that are not aware of that. We have a hack in the pgoutput plugin to ignore those, but we knew that was a hack. So here is an attempt at a more