Re: handle a ECPG_bytea typo

2020-07-26 Thread Michael Paquier
On Sat, Jul 25, 2020 at 06:17:42PM +0900, Michael Paquier wrote: > ECPGset_noind_null() and ECPGis_noind_null() in misc.c show that > ECPGgeneric_bytea is attached to ECPGt_bytea. The two structures may > be the same now, but if a bug fix or a code change involves a change > in the structure defin

Re: handle a ECPG_bytea typo

2020-07-25 Thread Michael Paquier
On Sat, Jul 25, 2020 at 07:22:15AM +0530, vignesh C wrote: > I felt the changes look correct. The reason it might be working > earlier is because the structure members are the same for both the > data structures ECPGgeneric_bytea & ECPGgeneric_varchar. ECPGset_noind_null() and ECPGis_noind_null()

Re: handle a ECPG_bytea typo

2020-07-24 Thread vignesh C
On Fri, Jul 24, 2020 at 1:35 PM Wang, Shenhao wrote: > > Hi, hackers > > The source looks like: > > case ECPGt_bytea: > { > struct ECPGgeneric_varchar *variable = > (struct ECPGgeneric_varchar *) (var->value); > > .. > } >

handle a ECPG_bytea typo

2020-07-24 Thread Wang, Shenhao
Hi, hackers The source looks like: case ECPGt_bytea: { struct ECPGgeneric_varchar *variable = (struct ECPGgeneric_varchar *) (var->value); .. } I think the developer intend to use struct ECPGgeneric_bytea instead of str