Re: genbki.pl not quoting keywords in postgres.bki output

2018-05-05 Thread Tom Lane
Mark Dilger writes: > There are not yet any examples in the postgres sources where this > oversight causes problems, but in genbki.pl, where it makes the > decision whether to quote a token: ... > it should also quote anything that is a keyword, such as "open", as > otherwise you get a syntax erro

genbki.pl not quoting keywords in postgres.bki output

2018-05-04 Thread Mark Dilger
Hackers, There are not yet any examples in the postgres sources where this oversight causes problems, but in genbki.pl, where it makes the decision whether to quote a token: # Quote value if needed. We need not quote values that satisfy # the "id" pattern in bootscanner.l, curren