Re: gai_strerror() is not thread-safe on Windows

2024-02-11 Thread Thomas Munro
On Tue, Jan 16, 2024 at 8:52 AM Robert Haas wrote: > On Wed, Dec 6, 2023 at 8:45 PM Kyotaro Horiguchi > wrote: > > > So I think we should just hard-code the error messages in English and > > > move on. However, English is my language so perhaps I should abstain > > > and leave it to others to de

Re: gai_strerror() is not thread-safe on Windows

2024-01-25 Thread vignesh C
On Tue, 5 Dec 2023 at 00:57, Thomas Munro wrote: > > On second thoughts, I guess it would make more sense to use the exact > messages Windows' own implementation would return instead of whatever > we had in the past (probably cribbed from some other OS or just made > up?). I asked CI to spit thos

Re: gai_strerror() is not thread-safe on Windows

2024-01-15 Thread Robert Haas
On Wed, Dec 6, 2023 at 8:45 PM Kyotaro Horiguchi wrote: > > So I think we should just hard-code the error messages in English and > > move on. However, English is my language so perhaps I should abstain > > and leave it to others to decide how important that is. > > I also think that would be a g

Re: gai_strerror() is not thread-safe on Windows

2023-12-06 Thread Kyotaro Horiguchi
At Thu, 7 Dec 2023 09:43:37 +1300, Thomas Munro wrote in > On Tue, Dec 5, 2023 at 3:43 PM Kyotaro Horiguchi > wrote: > > Windows' gai_strerror outputs messages that correspond to the language > > environment. Similarly, I think that the messages that the messages > > returned by our version sho

Re: gai_strerror() is not thread-safe on Windows

2023-12-06 Thread Thomas Munro
On Tue, Dec 5, 2023 at 3:43 PM Kyotaro Horiguchi wrote: > At Tue, 5 Dec 2023 08:26:54 +1300, Thomas Munro > wrote in > > On second thoughts, I guess it would make more sense to use the exact > > messages Windows' own implementation would return instead of whatever > > we had in the past (probabl

Re: gai_strerror() is not thread-safe on Windows

2023-12-04 Thread Kyotaro Horiguchi
At Tue, 5 Dec 2023 08:26:54 +1300, Thomas Munro wrote in > On second thoughts, I guess it would make more sense to use the exact > messages Windows' own implementation would return instead of whatever > we had in the past (probably cribbed from some other OS or just made > up?). I asked CI to s

Re: gai_strerror() is not thread-safe on Windows

2023-12-04 Thread Thomas Munro
On second thoughts, I guess it would make more sense to use the exact messages Windows' own implementation would return instead of whatever we had in the past (probably cribbed from some other OS or just made up?). I asked CI to spit those out[1]. Updated patch attached. Will add to CF. [1] htt

gai_strerror() is not thread-safe on Windows

2023-12-03 Thread Thomas Munro
Hi, Commit 5579388d removed a bunch of dead code, formerly needed for old systems that lacked getaddrinfo() in the early days of IPv6. We already used the system getaddrinfo() via either configure-time tests (Unix) or runtime tests (Windows using attempt-to-find-with-dlsym that always succeeded o