Re: fix: propagate M4 env variable to flex subprocess

On Mon, Jun 30, 2025 at 11:25 AM Peter Eisentraut wrote: > On 17.06.25 07:15, Peter Eisentraut wrote: > > On 28.05.25 20:42, J. Javier Maestro wrote: > >> On Wed, May 28, 2025 at 6:08 PM Andres Freund >> > wrote: > >> > >> Hi, > >> > >> On 2025-05-17 23:32:24 -

Re: fix: propagate M4 env variable to flex subprocess

On 17.06.25 07:15, Peter Eisentraut wrote: On 28.05.25 20:42, J. Javier Maestro wrote: On Wed, May 28, 2025 at 6:08 PM Andres Freund > wrote:     Hi,     On 2025-05-17 23:32:24 -0400, J. Javier Maestro wrote: > On Tue, May 13, 2025 at 11:54 AM Andres Freund    

Re: fix: propagate M4 env variable to flex subprocess

On Sun, Jun 22, 2025 at 10:23 PM Nikolay Samokhvalov wrote: > > On Wed, May 28, 2025 at 11:43 AM J. Javier Maestro > wrote: > >> On Wed, May 28, 2025 at 6:08 PM Andres Freund wrote: >> > ... > >> Do you want to write a patch like that? Otherwise I can. >>> >> >> Sure, I've attached the new patc

Re: fix: propagate M4 env variable to flex subprocess

On Tue, Jun 17, 2025 at 6:15 AM Peter Eisentraut wrote: > This patch looks right to me. > Great, thanks! I would wait for the PG19 branching at this point, unless there is a > concrete need for backpatching. This patch fixes just one of the issues I found when trying to have a reproducible PG

Re: fix: propagate M4 env variable to flex subprocess

On Wed, May 28, 2025 at 11:43 AM J. Javier Maestro wrote: > On Wed, May 28, 2025 at 6:08 PM Andres Freund wrote: > ... > Do you want to write a patch like that? Otherwise I can. >> > > Sure, I've attached the new patch. Let me know what you think, and if it's > OK, what are the next steps to ge

Re: fix: propagate M4 env variable to flex subprocess

On 28.05.25 20:42, J. Javier Maestro wrote: On Wed, May 28, 2025 at 6:08 PM Andres Freund > wrote: Hi, On 2025-05-17 23:32:24 -0400, J. Javier Maestro wrote: > On Tue, May 13, 2025 at 11:54 AM Andres Freund mailto:and...@anarazel.de>> wrote: > >

Re: fix: propagate M4 env variable to flex subprocess

On Wed, May 28, 2025 at 6:08 PM Andres Freund wrote: > Hi, > > On 2025-05-17 23:32:24 -0400, J. Javier Maestro wrote: > > On Tue, May 13, 2025 at 11:54 AM Andres Freund > wrote: > > > Bilal, I think you wrote this originally, do you recall? > > > > > > It seems like an issue beyond just M4... >

Re: fix: propagate M4 env variable to flex subprocess

Hi, On 2025-05-17 23:32:24 -0400, J. Javier Maestro wrote: > On Tue, May 13, 2025 at 11:54 AM Andres Freund wrote: > > Bilal, I think you wrote this originally, do you recall? > > > > It seems like an issue beyond just M4... > > > > IIRC the rest of the tools in the environment have ways to be s

Re: fix: propagate M4 env variable to flex subprocess

On Tue, May 20, 2025 at 8:53 AM Nazir Bilal Yavuz wrote: > Hi, > > On Tue, 13 May 2025 at 18:54, Andres Freund wrote: > > > > Hi, > > > > On 2025-05-12 23:14:59 -0400, J. Javier Maestro wrote: > > > The pgflex wrapper runs flex with an explicit environment, so it > doesn't > > > inherit environm

Re: fix: propagate M4 env variable to flex subprocess

Hi, On Tue, 13 May 2025 at 18:54, Andres Freund wrote: > > Hi, > > On 2025-05-12 23:14:59 -0400, J. Javier Maestro wrote: > > The pgflex wrapper runs flex with an explicit environment, so it doesn't > > inherit environment variables from the parent process. However, flex can > > use the M4 env va

Re: fix: propagate M4 env variable to flex subprocess

On Tue, May 13, 2025 at 11:54 AM Andres Freund wrote: > Hi, > > On 2025-05-12 23:14:59 -0400, J. Javier Maestro wrote: > > The pgflex wrapper runs flex with an explicit environment, so it doesn't > > inherit environment variables from the parent process. However, flex can > > use the M4 env varia

Re: fix: propagate M4 env variable to flex subprocess

Hi, On 2025-05-12 23:14:59 -0400, J. Javier Maestro wrote: > The pgflex wrapper runs flex with an explicit environment, so it doesn't > inherit environment variables from the parent process. However, flex can > use the M4 env variable and/or the PATH (via execvp) to find the m4 macro > processor.

fix: propagate M4 env variable to flex subprocess

Hi all, I was trying to build Postgres with Meson specifying the binaries of the tools such as bison, flex and m4. I found that the m4 binary wasn't being used by flex, and digging into this led me to the pgflex wrapper. The pgflex wrapper runs flex with an explicit environment, so it doesn't inh