On Jul 11, 2025, at 04:26, Florents Tselai wrote:
> Attached
Thank you! This looks great. The attached revision makes a a couple of minor
changes:
* Change the line wrap of the docs to be more like the rest of func.sgml
* Remove an unnecessary nested if statement
* Removed `==` from one of t
On Thu, Jul 10, 2025 at 11:55 PM David E. Wheeler
wrote:
> On Jul 10, 2025, at 16:38, Florents Tselai
> wrote:
>
> > Why isn’t this sufficient?
> >
> > static uint64
> > pg_base64_encode_internal(const char *src, size_t len, char *dst, bool
> url)
> > {
> > const char *alphabet = url ? _base64ur
On Jul 10, 2025, at 16:38, Florents Tselai wrote:
> Why isn’t this sufficient?
>
> static uint64
> pg_base64_encode_internal(const char *src, size_t len, char *dst, bool url)
> {
> const char *alphabet = url ? _base64url : _base64;
Ah, it is. I hadn’t got that far. I was tripped up to see this
> On 10 Jul 2025, at 10:07 PM, David E. Wheeler wrote:
>
> Hi Florents,
>
> On Jul 9, 2025, at 23:25, Florents Tselai wrote:
>
>>> I reviewed and tested v4. To me it looks as good as it will get.
>>> Personally I would change a few minor things here and there and
>>> probably merge all three
Hi Florents,
On Jul 9, 2025, at 23:25, Florents Tselai wrote:
>> I reviewed and tested v4. To me it looks as good as it will get.
>> Personally I would change a few minor things here and there and
>> probably merge all three patches into a single commit. This however is
>> up to the committer to
Thanks for the review Aleksander,
> On 9 Jul 2025, at 10:45 PM, Aleksander Alekseev
> wrote:
>
> Hi Florents,
>
> Thanks for the update!
>
>> here's a v4 patch set
>>
>> - Extracted pg_base64_{en,de}_internal with an additional bool url param,
>> to be used by other functions
>> - Added a
Hi Florents,
Thanks for the update!
> here's a v4 patch set
>
> - Extracted pg_base64_{en,de}_internal with an additional bool url param, to
> be used by other functions
> - Added a few more test cases
>
> Cary mentioned above
>
> > In addition, you may also want to add the C versions of base64
Thanks for the review Aleksander;
On Mon, Mar 31, 2025 at 5:37 PM Aleksander Alekseev <
aleksan...@timescale.com> wrote:
> Hi Florents,
>
> > Here's a v3 with some (hopefully) better test cases.
>
> Thanks for the new version of the patch.
>
> ```
> +encoded_len = pg_base64_encode(src, len, d
Hi,
In the strings.sql file there is such code
SELECT encode('\x69b73eff', 'base64'); -- Expected: abc+/w==
In the strings.out file
+SELECT encode('\x69b73eff', 'base64'); -- Expected: abc+/w==
+ encode
+--
+ abc+/w==
+(1 row)
+
maybe you should remove the additional description of the e
Hi Florents,
> Here's a v3 with some (hopefully) better test cases.
Thanks for the new version of the patch.
```
+encoded_len = pg_base64_encode(src, len, dst);
+
+/* Convert Base64 to Base64URL */
+for (uint64 i = 0; i < encoded_len; i++) {
+if (dst[i] == '+')
+d
On Tue, Mar 11, 2025 at 10:08 AM Florents Tselai
wrote:
>
>
> On Tue, Mar 11, 2025 at 12:51 AM Cary Huang wrote:
>
>> > Oh well - you're probably right.
>> > I guess I was blinded by my convenience.
>> > Adding a 'base64url' option there is more appropriate.
>>
>> I agree with it too. It is neat
> Oh well - you're probably right.
> I guess I was blinded by my convenience.
> Adding a 'base64url' option there is more appropriate.
I agree with it too. It is neater to add "base64url" as a new option for
encode() and decode() SQL functions in encode.c.
In addition, you may also want to add th
On Tue, Mar 11, 2025 at 12:51 AM Cary Huang wrote:
> > Oh well - you're probably right.
> > I guess I was blinded by my convenience.
> > Adding a 'base64url' option there is more appropriate.
>
> I agree with it too. It is neater to add "base64url" as a new option for
> encode() and decode() SQL
On 07.03.2025 15:40, Aleksander Alekseev wrote:
Hi,
Sometimes support for base64url from RFC 4648 would be useful.
Does anyone else need a patch like this?
While not a frequent ask, it has been mentioned in the past. I think it would
make sense to add so please do submit a patch for it for co
On Mon, Mar 10, 2025, 14:32 Daniel Gustafsson wrote:
> > On 10 Mar 2025, at 12:28, Florents Tselai
> wrote:
>
> > Here's a C implementation for this, along with some tests and
> documentation.
> > Tests are copied from cpython's implementation of urlsafe_b64encode and
> urlsafe_b64decode.
>
> +
> On 10 Mar 2025, at 12:28, Florents Tselai wrote:
> Here's a C implementation for this, along with some tests and documentation.
> Tests are copied from cpython's implementation of urlsafe_b64encode and
> urlsafe_b64decode.
+ base64url_encode ( input
bytea )
Shouldn't this be modelle
On Sun, Mar 9, 2025 at 12:28 AM Florents Tselai
wrote:
>
>
> On 7 Mar 2025, at 4:40 PM, Aleksander Alekseev
> wrote:
>
> Hi,
>
> Sometimes support for base64url from RFC 4648 would be useful.
> Does anyone else need a patch like this?
>
>
> While not a frequent ask, it has been mentioned in the
> On 7 Mar 2025, at 4:40 PM, Aleksander Alekseev
> wrote:
>
> Hi,
>
>>> Sometimes support for base64url from RFC 4648 would be useful.
>>> Does anyone else need a patch like this?
>>
>> While not a frequent ask, it has been mentioned in the past. I think it
>> would
>> make sense to add so
Hi,
> > Sometimes support for base64url from RFC 4648 would be useful.
> > Does anyone else need a patch like this?
>
> While not a frequent ask, it has been mentioned in the past. I think it would
> make sense to add so please do submit a patch for it for consideration.
IMO it would be nice to
> On 4 Mar 2025, at 09:54, Przemysław Sztoch wrote:
> Sometimes support for base64url from RFC 4648 would be useful.
> Does anyone else need a patch like this?
While not a frequent ask, it has been mentioned in the past. I think it would
make sense to add so please do submit a patch for it for
Hello,
Sometimes support for base64url from RFC 4648 would be useful.
Does anyone else need a patch like this?
--
Przemysław Sztoch | Mobile +48 509 99 00 66
21 matches
Mail list logo
