Re: enable_timeout_every() and fin_time

2023-01-03 Thread Robert Haas
On Tue, Jan 3, 2023 at 3:14 PM Andres Freund wrote: > Doesn't that discrepancy already exist as the code stands, because > startup_progress_phase_start_time is also set in > has_startup_progress_timeout_expired()? I don't think it is, actually. > I realize that was an example, but the > issue se

Re: enable_timeout_every() and fin_time

2023-01-03 Thread Andres Freund
Hi, On 2023-01-03 13:33:34 -0500, Robert Haas wrote: > On Sun, Jan 1, 2023 at 7:36 PM Andres Freund wrote: > > What is the use case for an absolute start time plus a relative > > interval? > > The code snippet that you indicate has the important side effect of > changing the global variable star

Re: enable_timeout_every() and fin_time

2023-01-03 Thread Robert Haas
On Sun, Jan 1, 2023 at 7:36 PM Andres Freund wrote: > What is the use case for an absolute start time plus a relative > interval? The code snippet that you indicate has the important side effect of changing the global variable startup_progress_phase_start_time, which is used by has_startup_progre

enable_timeout_every() and fin_time

2023-01-01 Thread Andres Freund
Hi, I was looking using enable_timeout_every() in another place with Lukas just now, and noticed the fin_time argument. It seems odd for an interval firing interface to get an absolute timestamp as an argument. The only in-tree user of enable_timeout_every() computes fin_time explicitly using the