Re: duplicated comments on get_relation_constraints

2025-04-05 Thread Richard Guo
On Sat, Mar 29, 2025 at 1:38 AM Kirill Reshke wrote: > On Fri, 28 Mar 2025 at 15:19, Richard Guo wrote: > > On Fri, Mar 28, 2025 at 4:53 PM Kirill Reshke > > wrote: > > > On Fri, 28 Mar 2025 at 09:47, jian he wrote: > > > > The first "Also ignore if NO INHERIT and we weren't told that that's >

Re: duplicated comments on get_relation_constraints

2025-04-03 Thread Richard Guo
On Wed, Apr 2, 2025 at 11:39 AM Richard Guo wrote: > The change looks good to me. I plan to push it soon, barring any > objections. Pushed. Thanks Richard

Re: duplicated comments on get_relation_constraints

2025-03-28 Thread Kirill Reshke
On Fri, 28 Mar 2025 at 15:19, Richard Guo wrote: > > On Fri, Mar 28, 2025 at 4:53 PM Kirill Reshke wrote: > > On Fri, 28 Mar 2025 at 09:47, jian he wrote: > > > The first "Also ignore if NO INHERIT and we weren't told that that's > > > safe." is duplicated, > > > also it's in the wrong place? >

Re: duplicated comments on get_relation_constraints

2025-03-28 Thread Kirill Reshke
On Fri, 28 Mar 2025 at 09:47, jian he wrote: > > hi. > > in plancat.c, function: get_relation_constraints > > ``` > for (i = 0; i < num_check; i++) > { > Node *cexpr; > /* > * If this constraint hasn't been fully validated yet, we must > * ignore it here. Also ignore if

Re: duplicated comments on get_relation_constraints

2025-03-28 Thread Richard Guo
On Fri, Mar 28, 2025 at 4:53 PM Kirill Reshke wrote: > On Fri, 28 Mar 2025 at 09:47, jian he wrote: > > The first "Also ignore if NO INHERIT and we weren't told that that's > > safe." is duplicated, > > also it's in the wrong place? > > The second one is fine. > Hi! Indeed. Looks like an oversig

duplicated comments on get_relation_constraints

2025-03-27 Thread jian he
hi. in plancat.c, function: get_relation_constraints ``` for (i = 0; i < num_check; i++) { Node *cexpr; /* * If this constraint hasn't been fully validated yet, we must * ignore it here. Also ignore if NO INHERIT and we weren't told * that that's safe. */