Re: doing something about the broken dynloader.h symlink

2021-02-14 Thread Thomas Munro
On Fri, Jun 19, 2020 at 11:38 PM Julien Rouhaud wrote: > On Fri, Jun 19, 2020 at 12:08 PM Thomas Munro wrote: > > On Fri, Jun 19, 2020 at 8:02 PM Peter Eisentraut > > wrote: > > > +[# Remove links created by old versions of configure, so that there > > > +# are no broken symlinks in the tree > >

Re: doing something about the broken dynloader.h symlink

2020-06-19 Thread Tom Lane
Peter Eisentraut writes: > When you switch a built REL_11_STABLE or earlier to REL_12_STABLE or > later, you get during make install (or, therefore, make check) an error While I don't necessarily object to the hack you propose here, it seems to me that really we need to caution people more stron

Re: doing something about the broken dynloader.h symlink

2020-06-19 Thread Julien Rouhaud
On Fri, Jun 19, 2020 at 12:08 PM Thomas Munro wrote: > > On Fri, Jun 19, 2020 at 8:02 PM Peter Eisentraut > wrote: > > +[# Remove links created by old versions of configure, so that there > > +# are no broken symlinks in the tree > > +rm -f src/include/dynloader.h]) > > +1 +1

Re: doing something about the broken dynloader.h symlink

2020-06-19 Thread Michael Paquier
On Fri, Jun 19, 2020 at 10:08:05PM +1200, Thomas Munro wrote: > On Fri, Jun 19, 2020 at 8:02 PM Peter Eisentraut > wrote: >> +[# Remove links created by old versions of configure, so that there >> +# are no broken symlinks in the tree >> +rm -f src/include/dynloader.h]) > > +1 Not sure about you

Re: doing something about the broken dynloader.h symlink

2020-06-19 Thread Thomas Munro
On Fri, Jun 19, 2020 at 8:02 PM Peter Eisentraut wrote: > +[# Remove links created by old versions of configure, so that there > +# are no broken symlinks in the tree > +rm -f src/include/dynloader.h]) +1

doing something about the broken dynloader.h symlink

2020-06-19 Thread Peter Eisentraut
When you switch a built REL_11_STABLE or earlier to REL_12_STABLE or later, you get during make install (or, therefore, make check) an error cp ./*.h 'PREFIX/include/server'/ cp: cannot stat './dynloader.h': No such file or directory This is because version 11 and earlier created src/include/dy