Re: documentation about explicit locking

2018-07-30 Thread Amit Langote
On 2018/07/31 5:27, Peter Eisentraut wrote: > On 19/07/2018 06:17, Amit Langote wrote: >> When playing with this, I observed that a less user-friendly error message >> is emitted if multiple sessions race to create the same collation. >> >> Session 1: >> begin; >> create collation collname (...); >

Re: documentation about explicit locking

2018-07-30 Thread Amit Langote
On 2018/07/31 5:25, Peter Eisentraut wrote: > On 20/07/2018 02:30, Amit Langote wrote: >> We don't explicitly mention what locks we take on system catalogs >> elsewhere, but CREATE COLLATION is different from other commands, so I'm >> fine with adding more details as you suggest, so updated the tex

Re: documentation about explicit locking

2018-07-30 Thread Peter Eisentraut
On 19/07/2018 06:17, Amit Langote wrote: > When playing with this, I observed that a less user-friendly error message > is emitted if multiple sessions race to create the same collation. > > Session 1: > begin; > create collation collname (...); > > Session 2: > create collation collname (...); >

Re: documentation about explicit locking

2018-07-30 Thread Peter Eisentraut
On 20/07/2018 02:30, Amit Langote wrote: > We don't explicitly mention what locks we take on system catalogs > elsewhere, but CREATE COLLATION is different from other commands, so I'm > fine with adding more details as you suggest, so updated the text. committed the documentation change -- Peter

Re: documentation about explicit locking

2018-07-19 Thread Amit Langote
Horiguchi-san, Thanks for taking a look. On 2018/07/19 18:23, Kyotaro HORIGUCHI wrote: > Hello. > > At Thu, 19 Jul 2018 13:17:14 +0900, Amit Langote wrote: >> On 2018/07/18 18:30, Peter Eisentraut wrote: >>> The reason this is mentioned is that CREATE COLLATION takes a SHARE ROW >>> EXCLUSIVE lo

Re: documentation about explicit locking

2018-07-19 Thread Kyotaro HORIGUCHI
Hello. At Thu, 19 Jul 2018 13:17:14 +0900, Amit Langote wrote in <85dc6464-eb59-ba59-75d3-09b292fa8...@lab.ntt.co.jp> > On 2018/07/18 18:30, Peter Eisentraut wrote: > > On 06.07.18 04:00, Amit Langote wrote: > >> On 2018/07/05 23:02, Robert Haas wrote: > >>> On Wed, Jul 4, 2018 at 3:09 AM, Amit

Re: documentation about explicit locking

2018-07-18 Thread Amit Langote
On 2018/07/18 18:30, Peter Eisentraut wrote: > On 06.07.18 04:00, Amit Langote wrote: >> On 2018/07/05 23:02, Robert Haas wrote: >>> On Wed, Jul 4, 2018 at 3:09 AM, Amit Langote >>> wrote: I wonder why we mention on the following page that CREATE COLLATION requires SHARE ROW EXCLUSIVE lo

Re: documentation about explicit locking

2018-07-18 Thread Peter Eisentraut
On 06.07.18 04:00, Amit Langote wrote: > On 2018/07/05 23:02, Robert Haas wrote: >> On Wed, Jul 4, 2018 at 3:09 AM, Amit Langote >> wrote: >>> I wonder why we mention on the following page that CREATE COLLATION >>> requires SHARE ROW EXCLUSIVE lock >>> >>> https://www.postgresql.org/docs/devel/sta

Re: documentation about explicit locking

2018-07-05 Thread Amit Langote
On 2018/07/05 23:02, Robert Haas wrote: > On Wed, Jul 4, 2018 at 3:09 AM, Amit Langote > wrote: >> I wonder why we mention on the following page that CREATE COLLATION >> requires SHARE ROW EXCLUSIVE lock >> >> https://www.postgresql.org/docs/devel/static/explicit-locking.html >> >> I know that's t

Re: documentation about explicit locking

2018-07-05 Thread Robert Haas
On Wed, Jul 4, 2018 at 3:09 AM, Amit Langote wrote: > I wonder why we mention on the following page that CREATE COLLATION > requires SHARE ROW EXCLUSIVE lock > > https://www.postgresql.org/docs/devel/static/explicit-locking.html > > I know that's the lock taken on the pg_collation catalog, but do

documentation about explicit locking

2018-07-04 Thread Amit Langote
Hi. I wonder why we mention on the following page that CREATE COLLATION requires SHARE ROW EXCLUSIVE lock https://www.postgresql.org/docs/devel/static/explicit-locking.html I know that's the lock taken on the pg_collation catalog, but do we need to mention locks taken by a DDL command on the cat