Re: doc - improve description of default privileges

2018-12-03 Thread Fabien COELHO
I looked at the psql manpage and the HTML rendering of section 5.6 and it all looks good to me. Indeed, this looks great, a precise and full description of privileges just in one place. Pushed (with a little bit more tweaking). Thanks for the rewrite, extensions, improvements and final p

Re: doc - improve description of default privileges

2018-12-03 Thread Tom Lane
Fabien COELHO writes: >>> I feel if we're going to do anything, we should put a unified description >>> of privileges and aclitem-reading into section 5.6, and take that material >>> out of the various places where it lives now. Like the attached, in which >>> I failed to resist the temptation to

Re: doc - improve description of default privileges

2018-12-02 Thread Fabien COELHO
I feel if we're going to do anything, we should put a unified description of privileges and aclitem-reading into section 5.6, and take that material out of the various places where it lives now. Like the attached, in which I failed to resist the temptation to wordsmith some stuff as well as m

Re: doc - improve description of default privileges

2018-11-30 Thread Alvaro Herrera
On 2018-Nov-30, Tom Lane wrote: > I feel if we're going to do anything, we should put a unified description > of privileges and aclitem-reading into section 5.6, and take that material > out of the various places where it lives now. Like the attached, in which > I failed to resist the temptation

Re: doc - improve description of default privileges

2018-11-30 Thread Tom Lane
Fabien COELHO writes: > Attached v4: > - moves the table to the privileges section > - updates the table column headers > - adds a privilege/aclitem letter mapping table > - adds some appropriate links towards psql & aclitem TBH, I don't think this goes nearly far enough. It seems like i

Re: doc - improve description of default privileges

2018-11-18 Thread Fabien COELHO
Hello Tom, Thanks for this precise feedback. Progress on this patch seems to be blocked on the question of whether we want to keep enlarging the amount of psql-specific information in the GRANT reference page, or move that all somewhere else. Yep. FWIW, I think I agree with Peter's positio

Re: doc - improve description of default privileges

2018-11-14 Thread Tom Lane
Progress on this patch seems to be blocked on the question of whether we want to keep enlarging the amount of psql-specific information in the GRANT reference page, or move that all somewhere else. FWIW, I think I agree with Peter's position that moving it somewhere else is the better option. Sec

Re: doc - improve description of default privileges

2018-09-30 Thread Michael Paquier
On Fri, Sep 28, 2018 at 04:15:13PM -0300, Alvaro Herrera wrote: > There is a legitimate point in doing this, though, since the GRANT page > is already explaining how does psql display privileges. Maybe the right > solution is move that stuff all to the psql documentation, and alter the > GRANT pag

Re: doc - improve description of default privileges

2018-09-29 Thread Fabien COELHO
The Owner column is redundant, because it's always all applicable privileges. (Having this column would give the impression that it's not always all privileges, so it would be confusing.) The reason I put the owner column is to show (1) the privileges that apply to the objects (i.e. what is

Re: doc - improve description of default privileges

2018-09-28 Thread Alvaro Herrera
On 2018-Sep-28, Peter Eisentraut wrote: > The psql commands seem out of place here. If you want to learn about > how to use psql, you can go to the psql documentation. There is a legitimate point in doing this, though, since the GRANT page is already explaining how does psql display privileges.

Re: doc - improve description of default privileges

2018-09-28 Thread Peter Eisentraut
Some thoughts: We should keep the GRANT reference page about GRANT. There is a section about Privileges in the Data Definition chapter, which we could use to expand on general concepts. The ALTER DEFAULT PRIVILEGES reference page would be another place this could be put. The Owner column is red

Re: Re[3]: doc - improve description of default privileges

2018-09-14 Thread Brad DeJong
On 2018-09-12 Tom Lane wrote ... > The reviewer does that, indicating signoff. Thanks. I have now changed the status to "Ready for Committer".

Re: Re[3]: doc - improve description of default privileges

2018-09-12 Thread Tom Lane
"Bradley DeJong" writes: > Is the reviewer supposed to move this to "ready for committer" or is the > author supposed to do that? The reviewer does that, indicating signoff. regards, tom lane

Re[3]: doc - improve description of default privileges

2018-09-12 Thread Bradley DeJong
on 2018-08-30, Fabien Coelho wrote ... > ... Find v3 attached. ... Hi Fabien, As we're coming up on the end of this commitfest ... Is the reviewer supposed to move this to "ready for committer" or is the author supposed to do that? Is the reviewer supposed to explicitly state "I've looked at

Re[2]: doc - improve description of default privileges

2018-08-30 Thread Fabien COELHO
Hello Bradley, comments on the patch ... Thanks for the review. 1) I think that adding the "This privilege is abbreviated ... when displayed." lines to the privilege descriptions is redundant. The abbreviations are already listed after the "The entries shown by \dp are interpreted thus:"

Re[2]: doc - improve description of default privileges

2018-08-27 Thread Bradley DeJong
bien COELHO" To: "PostgreSQL Developers" Sent: 8/4/2018 4:40:33 AM Subject: Re: doc - improve description of default privileges I have not found a convenient presentation of the default privileges for different objects, and how to display them (if possible, not always). Th

Re: doc - improve description of default privileges

2018-08-04 Thread Fabien COELHO
I have not found a convenient presentation of the default privileges for different objects, and how to display them (if possible, not always). The information is partly provided within the GRANT description, and not very explicit: eg it is said that owners have all possible perms, but which t

doc - improve description of default privileges

2018-07-31 Thread Fabien COELHO
I have not found a convenient presentation of the default privileges for different objects, and how to display them (if possible, not always). The information is partly provided within the GRANT description, and not very explicit: eg it is said that owners have all possible perms, but which