On 2024/07/09 15:56, ikedarintarof wrote:
- * Validate connection info string, and determine whether it might cause
- * local filesystem access to be attempted.
+ * The function
+ * 1. validates connection info string and
+ * 2. checks a password is provided if must_use_password is true.
IMO,
- * Validate connection info string, and determine whether it might
cause
- * local filesystem access to be attempted.
+ * The function
+ * 1. validates connection info string and
+ * 2. checks a password is provided if must_use_password is true.
IMO, "Validate connection info string" is suffici
On 2024/07/08 20:44, ikedarintarof wrote:
I remove the unclear part from the previous patch and add some explanation for
later part of the function.
- * Validate connection info string, and determine whether it might cause
- * local filesystem access to be attempted.
+ * The function
+ * 1
On 2024-07-08 15:28, Fujii Masao wrote:
On 2024/07/01 18:15, Jelte Fennema-Nio wrote:
On Thu, 27 Jun 2024 at 12:27, ikedarintarof
wrote:
Thanks for your suggestion. I used ChatGPT to choose the wording, but
it's still difficult for me.
Looks good to me now (but obviously biased since you too
On 2024/07/01 18:15, Jelte Fennema-Nio wrote:
On Thu, 27 Jun 2024 at 12:27, ikedarintarof
wrote:
Thanks for your suggestion. I used ChatGPT to choose the wording, but
it's still difficult for me.
Looks good to me now (but obviously biased since you took my wording).
LGTM, too.
* Valid
On Thu, 27 Jun 2024 at 12:27, ikedarintarof
wrote:
> Thanks for your suggestion. I used ChatGPT to choose the wording, but
> it's still difficult for me.
Looks good to me now (but obviously biased since you took my wording).
Adding Robert, since he authored the commit that introduced this
comment
Thanks for your suggestion. I used ChatGPT to choose the wording, but
it's still difficult for me.
The new patch includes your suggestion.
On 2024-06-27 17:18, Jelte Fennema-Nio wrote:
On Thu, 27 Jun 2024 at 09:09, ikedarintarof
wrote:
Thank you for your comment!
I've added the must_use_pa
On Thu, 27 Jun 2024 at 09:09, ikedarintarof
wrote:
>
> Thank you for your comment!
>
> I've added the must_use_password argument. A new patch is attached.
s/whther/whether
nit: "it will do nothing" sounds a bit strange to me (but I'm not
native english). Something like this reads more natural to
Thank you for your comment!
I've added the must_use_password argument. A new patch is attached.
On 2024-06-26 23:36, Jelte Fennema-Nio wrote:
On Wed, 26 Jun 2024 at 14:53, ikedarintarof
wrote:
The function 'libpqrcv_check_conninfo()' returns 'void', but the
comment
above says that the funct
On Wed, 26 Jun 2024 at 14:53, ikedarintarof
wrote:
> The function 'libpqrcv_check_conninfo()' returns 'void', but the comment
> above says that the function returns true or false.
> I've attached a patch to modify the comment.
Agreed that the current comment is wrong, but the new comment should
m
Hi,
The function 'libpqrcv_check_conninfo()' returns 'void', but the comment
above says that the function returns true or false.
I've attached a patch to modify the comment.
Regard,
Rintaro Ikedadiff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/
11 matches
Mail list logo
