Re: disabled SSL log_like tests

2025-04-22 Thread Tom Lane
I wrote: > The fact that mamba hasn't been failing on the other affected > tests is a bit puzzling. mamba isn't running kerberos or ldap > or oauth_validator, so the lack of failures there is expected. > authentication/t/001_password.pl appears accidentally not vulnerable: > it's not using log_lik

Re: disabled SSL log_like tests

2025-04-19 Thread Tom Lane
Andrew Dunstan writes: > On 2025-04-18 Fr 7:26 PM, Tom Lane wrote: > +See C.  CAUTION: use of either option requires that > +the server's log_min_messages be at least DEBUG2, and that no other > +client backend is launched concurrently.  These requirements allow > +C to wait to see the postmaster-

Re: disabled SSL log_like tests

2025-04-19 Thread Andrew Dunstan
On 2025-04-18 Fr 7:26 PM, Tom Lane wrote: I wrote: What I think happened here is that a previous backend hadn't exited yet when we start the test, and when its report does come out, connect_fails prematurely stops waiting. (In the above, evidently the child process we want to wait for is 599,

Re: disabled SSL log_like tests

2025-04-18 Thread Tom Lane
I wrote: > What I think happened here is that a previous backend hadn't exited > yet when we start the test, and when its report does come out, > connect_fails prematurely stops waiting. (In the above, evidently > the child process we want to wait for is 599, but we're fooled by > a delayed report

Re: disabled SSL log_like tests

2025-04-18 Thread Tom Lane
I wrote: > * I was more than slightly surprised to find that there are a bunch of > other connect_fails callers that are testing log_like or log_unlike > and thereby risking the same type of race condition. Some of those > tests are relatively new and perhaps just haven't failed *yet*, > but I won

Re: disabled SSL log_like tests

2025-04-18 Thread Jacob Champion
On Fri, Apr 18, 2025 at 12:46 PM Tom Lane wrote: > * The commented-out tests in 001_ssltests.pl contained hard-wired > expectations as to certificate serial numbers, which are obsolete now. > I just replaced them with "\d+", but if anyone feels like that's not > good enough, we could continue to c

Re: disabled SSL log_like tests

2025-04-18 Thread Tom Lane
Andrew Dunstan writes: > On 2025-04-17 Th 10:56 AM, Tom Lane wrote: >> However, I wonder whether Andres' work at 8b886a4e3 could be used >> to improve this, either directly or as inspiration? > I don't think so - these tests are about checking log file contents, not > a psql problem. Well, I wa

Re: disabled SSL log_like tests

2025-04-17 Thread Andrew Dunstan
On 2025-04-17 Th 10:56 AM, Tom Lane wrote: Andrew Dunstan writes: Back in 2022 in commit 55828a6b6084 we disabled a bunch of tests due to a timing issue. Nothing seems to have been done since ... do we still want to keep these commented out lines around? This "temporary" fix seems to have str

Re: disabled SSL log_like tests

2025-04-17 Thread Tom Lane
Andrew Dunstan writes: > Back in 2022 in commit 55828a6b6084 we disabled a bunch of tests due to > a timing issue. Nothing seems to have been done since ... do we still > want to keep these commented out lines around? This "temporary" fix > seems to have stretched the definition of that term mo

disabled SSL log_like tests

2025-04-17 Thread Andrew Dunstan
Back in 2022 in commit 55828a6b6084 we disabled a bunch of tests due to a timing issue. Nothing seems to have been done since ... do we still want to keep these commented out lines around? This "temporary" fix seems to have stretched the definition of that term more than somewhat. (noticed whe