Re: de-catalog one error message

2023-05-16 Thread Alvaro Herrera
On 2023-May-11, Daniel Gustafsson wrote: > > On 10 May 2023, at 19:54, Alvaro Herrera wrote: > > Therefore, I propose to turn these messages into errmsg_internal(), so > > that we do not translate them. > > AFAICT from following the code that seems correct, and I agree with removing > them from

Re: de-catalog one error message

2023-05-11 Thread Daniel Gustafsson
> On 10 May 2023, at 19:54, Alvaro Herrera wrote: > ..as I understand, this cannot happen merely because of a full > disk, because that should fail during _write_ of the file, not read. > And no other user-caused causes should exist. > > Therefore, I propose to turn these messages into errmsg_i

de-catalog one error message

2023-05-10 Thread Alvaro Herrera
Hi While translating the v15 message catalog (yes, I'm quite late!), I noticed that commit 1f39bce02154 introduced three copies of the following message in hashagg_batch_read(): + ereport(ERROR, + (errcode_for_file_access(), +errmsg("unexpected EOF for tape %d: