Re: crash with synchronized_standby_slots

2024-12-03 Thread Amit Kapila
On Tue, Dec 3, 2024 at 10:34 PM Alvaro Herrera wrote: > > On 2024-Nov-29, Amit Kapila wrote: > > BTW it occurs to me that there might well be some sort of thundering > herd problem if every process needs to run the check_hook when a SIGHUP > is broadcast, and they'll all be waiting on that particu

Re: crash with synchronized_standby_slots

2024-12-03 Thread Alvaro Herrera
On 2024-Nov-29, Amit Kapila wrote: > I tried it on my Windows machine and noticed that ReplicationSlotCtl > is NULL for syslogger, so the problem doesn't occur. The reason is > that we don't attach to shared memory in syslogger, so ideally > ReplicationSlotCtl should be NULL. Because we inherit ev

RE: crash with synchronized_standby_slots

2024-11-29 Thread Zhijie Hou (Fujitsu)
On Thursday, November 28, 2024 8:16 PM Alvaro Herrera wrote: > > Gabriele just reported a crash when changing synchronized_standby_slots > under SIGHUP and logging collector working. The problem apparently is > that validate_sync_standby_slots is run for the GUC check routine, and > it requires

Re: crash with synchronized_standby_slots

2024-11-28 Thread Amit Kapila
On Thu, Nov 28, 2024 at 5:54 PM Alvaro Herrera wrote: > > Gabriele just reported a crash when changing synchronized_standby_slots > under SIGHUP and logging collector working. The problem apparently is > that validate_sync_standby_slots is run for the GUC check routine, and > it requires acquirin

crash with synchronized_standby_slots

2024-11-28 Thread Alvaro Herrera
Hello, Gabriele just reported a crash when changing synchronized_standby_slots under SIGHUP and logging collector working. The problem apparently is that validate_sync_standby_slots is run for the GUC check routine, and it requires acquiring an LWLock; but syslogger doesn't have a PGPROC so that