Re: constify arguments of copy_file() and copydir()

2023-01-17 Thread Nathan Bossart
On Wed, Jan 18, 2023 at 09:05:52AM +0900, Michael Paquier wrote: > Thanks, done. Thanks! -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: constify arguments of copy_file() and copydir()

2023-01-17 Thread Michael Paquier
On Tue, Jan 17, 2023 at 08:23:49PM +0100, Peter Eisentraut wrote: > Looks good to me. Thanks, done. -- Michael signature.asc Description: PGP signature

Re: constify arguments of copy_file() and copydir()

2023-01-17 Thread Peter Eisentraut
On 17.01.23 07:24, Michael Paquier wrote: On Mon, Jan 16, 2023 at 10:53:40AM +0900, Michael Paquier wrote: +1. While I don't forget about this thread.. Any objections if I were to apply that? Looks good to me.

Re: constify arguments of copy_file() and copydir()

2023-01-16 Thread Michael Paquier
On Mon, Jan 16, 2023 at 10:53:40AM +0900, Michael Paquier wrote: > +1. While I don't forget about this thread.. Any objections if I were to apply that? -- Michael signature.asc Description: PGP signature

Re: constify arguments of copy_file() and copydir()

2023-01-15 Thread Michael Paquier
On Sun, Jan 15, 2023 at 08:13:28AM -0800, Nathan Bossart wrote: > On Sun, Jan 15, 2023 at 08:23:13AM -0500, Andrew Dunstan wrote: >> On 2023-01-14 Sa 18:11, Nathan Bossart wrote: >>> I've attached a patch for $SUBJECT, which allows us to remove a use of the >>> unconstify macro in basic_archive. T

Re: constify arguments of copy_file() and copydir()

2023-01-15 Thread Nathan Bossart
On Sun, Jan 15, 2023 at 08:23:13AM -0500, Andrew Dunstan wrote: > On 2023-01-14 Sa 18:11, Nathan Bossart wrote: >> I've attached a patch for $SUBJECT, which allows us to remove a use of the >> unconstify macro in basic_archive. This is just a pet peeve, but maybe it >> bothers others, too. > > I

Re: constify arguments of copy_file() and copydir()

2023-01-15 Thread Andrew Dunstan
On 2023-01-14 Sa 18:11, Nathan Bossart wrote: > I've attached a patch for $SUBJECT, which allows us to remove a use of the > unconstify macro in basic_archive. This is just a pet peeve, but maybe it > bothers others, too. I don't like using unconstify where it can be avoided, so this looks rea

constify arguments of copy_file() and copydir()

2023-01-14 Thread Nathan Bossart
I've attached a patch for $SUBJECT, which allows us to remove a use of the unconstify macro in basic_archive. This is just a pet peeve, but maybe it bothers others, too. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com diff --git a/contrib/basic_archive/basic_archive.c b/contrib/bas