Hi,
On 2022-09-09 17:31:40 -0400, Tom Lane wrote:
> Harder for who? AFAICT there is nobody but me routinely running
> full tests on NetBSD, else we'd have found this problem much earlier.
Bilal's report was caused by automating testing on netbsd (and openbsd) as
well, as part of the meson stuff.
Andres Freund writes:
> On 2022-09-09 12:48:38 -0400, Tom Lane wrote:
>> Pushed with those changes and doc updates. I did not push the
>> variant expected-file. I think the entire point here is that
>> we are *not* deeming the new NetBSD implementation acceptable,
>> so allowing it to pass regre
Hi,
On 2022-09-09 12:48:38 -0400, Tom Lane wrote:
> Pushed with those changes and doc updates. I did not push the
> variant expected-file. I think the entire point here is that
> we are *not* deeming the new NetBSD implementation acceptable,
> so allowing it to pass regression tests is the wrong
Nazir Bilal Yavuz writes:
> I updated my patch. I checked version field in 'uuid_generate_internal'
> function instead of checking it in 'uuid_generate_v1' and
> 'uuid_generate_v1mc' functions, but I have some questions:
Yeah, that seems like the right place. I tweaked the code to check
strbuf
Hi,
On 8/26/22 19:21, Tom Lane wrote:
Nazir Bilal Yavuz writes:
Based on these discussions, I attached a patch.
I think the right fix is to call uuid_create and then actually check
the version field of the result. This avoids breaking what need not
be broken, and it'd also guard against co
Nazir Bilal Yavuz writes:
> Based on these discussions, I attached a patch.
This is the wrong way to go about it:
+#if defined(__NetBSD__)
+ ereport(ERROR, errmsg("NetBSD's uuid_create function generates "
+ "version-4 UUIDs
instead of
Hi,
On 8/21/22 04:37, Tom Lane wrote:
Andres Freund writes:
Perhaps we should make them error out instead? It doesn't seem helpful to
just return something wrong...
Yeah, might be appropriate.
Based on these discussions, I attached a patch.
Thanks,
Nazir Bilal Yavuzdiff --git a/contrib/uui
Andres Freund writes:
> On 2022-08-20 19:39:32 -0400, Tom Lane wrote:
>> In the course of setting up a NetBSD buildfarm animal, I discovered
>> that this is a lie.
> Also recently reported as a bug:
> https://postgr.es/m/17358-89806e7420797025%40postgresql.org
> with a bunch of discussion.
Ah,
Hi,
On 2022-08-20 19:39:32 -0400, Tom Lane wrote:
> Our documentation claims that --with-uuid=bsd works on both
> FreeBSD and NetBSD: installation.sgml says
>
>bsd to use the UUID functions found in FreeBSD,
> NetBSD,
>and some other BSD-derived systems
>
> and there is
Our documentation claims that --with-uuid=bsd works on both
FreeBSD and NetBSD: installation.sgml says
bsd to use the UUID functions found in FreeBSD,
NetBSD,
and some other BSD-derived systems
and there is comparable wording in uuid-ossp.sgml.
In the course of setting up
10 matches
Mail list logo
