Re: comments around heap_lock_tuple confus{ing,ed} around deleted tuples

2018-04-04 Thread Andres Freund
Hi, On 2018-04-04 18:34:26 -0300, Alvaro Herrera wrote: > > It's also fairly weird that heap_lock_updated_tuple() returns > > /* nothing to lock */ > > return HeapTupleMayBeUpdated; > > when the tuple has been deleted (and thus > > ItemPointerEquals(&tuple->t_self, ctid)). That'll not get

Re: comments around heap_lock_tuple confus{ing,ed} around deleted tuples

2018-04-04 Thread Alvaro Herrera
Andres Freund wrote: > While looking at resolving [1] I re-read heap_lock_tuple() and > subsidiary routines and got thoroughly confused for a while. > > One reason was that function names and comments talk about updated, when > they also actually deal with deletes. heap_lock_updated_tuple() > sp

comments around heap_lock_tuple confus{ing,ed} around deleted tuples

2018-04-04 Thread Andres Freund
Hi, While looking at resolving [1] I re-read heap_lock_tuple() and subsidiary routines and got thoroughly confused for a while. One reason was that function names and comments talk about updated, when they also actually deal with deletes. heap_lock_updated_tuple() specifically is called on tuple