Re: cleanup & refactoring on reindexdb.c

2019-07-01 Thread Julien Rouhaud
On Tue, Jul 2, 2019 at 4:44 AM Michael Paquier wrote: > > On Sat, Jun 29, 2019 at 11:24:49AM +0900, Michael Paquier wrote: > > Thanks for the rebase (and the reminder..). I'll look at that once > > v13 opens for business. > > And applied. Thanks!

Re: cleanup & refactoring on reindexdb.c

2019-07-01 Thread Michael Paquier
On Sat, Jun 29, 2019 at 11:24:49AM +0900, Michael Paquier wrote: > Thanks for the rebase (and the reminder..). I'll look at that once > v13 opens for business. And applied. -- Michael signature.asc Description: PGP signature

Re: cleanup & refactoring on reindexdb.c

2019-06-28 Thread Michael Paquier
On Fri, Jun 28, 2019 at 09:25:00AM +0200, Julien Rouhaud wrote: > The patch does not apply anymore, so here's a rebased version. Thanks for the rebase (and the reminder..). I'll look at that once v13 opens for business. -- Michael signature.asc Description: PGP signature

Re: cleanup & refactoring on reindexdb.c

2019-06-28 Thread Julien Rouhaud
On Mon, May 13, 2019 at 5:09 AM Michael Paquier wrote: > > On Sun, May 12, 2019 at 11:16:28AM +0200, Julien Rouhaud wrote: > > I attach two patches to fix both (it could be squashed in a single > > commit as both are straightforward), for upcoming v13. > > Squashing both patches together makes the

Re: cleanup & refactoring on reindexdb.c

2019-05-12 Thread Michael Paquier
On Sun, May 12, 2019 at 11:16:28AM +0200, Julien Rouhaud wrote: > I attach two patches to fix both (it could be squashed in a single > commit as both are straightforward), for upcoming v13. Squashing both patches together makes the most sense in my opinion as the same areas are reworked. I can no

cleanup & refactoring on reindexdb.c

2019-05-12 Thread Julien Rouhaud
Hi, As discussed in https://www.postgresql.org/message-id/caobau_yo61rwno3cw6wvywwh7eympuexhkqufb2nfgodunb...@mail.gmail.com, current coding in reindexdb.c is error prone, and reindex_system_catalogs() is also not really required. I attach two patches to fix both (it could be squashed in a single