Re: cleaning up PostgresNode.pm

2021-07-18 Thread Andrew Dunstan
On 7/18/21 11:48 AM, Andrew Dunstan wrote: > On 7/16/21 3:32 PM, Andrew Dunstan wrote: >> On 6/28/21 1:02 PM, Andrew Dunstan wrote: >>> On 4/24/21 3:14 PM, Alvaro Herrera wrote: On 2021-Apr-24, Andrew Dunstan wrote: > I would like to undertake some housekeeping on PostgresNode.pm. >>

Re: cleaning up PostgresNode.pm

2021-07-18 Thread Andrew Dunstan
On 7/16/21 3:32 PM, Andrew Dunstan wrote: > On 6/28/21 1:02 PM, Andrew Dunstan wrote: >> On 4/24/21 3:14 PM, Alvaro Herrera wrote: >>> On 2021-Apr-24, Andrew Dunstan wrote: >>> I would like to undertake some housekeeping on PostgresNode.pm. 1. OO modules in perl typically don't expo

Re: cleaning up PostgresNode.pm

2021-07-16 Thread Andrew Dunstan
On 6/28/21 1:02 PM, Andrew Dunstan wrote: > On 4/24/21 3:14 PM, Alvaro Herrera wrote: >> On 2021-Apr-24, Andrew Dunstan wrote: >> >>> I would like to undertake some housekeeping on PostgresNode.pm. >>> >>> 1. OO modules in perl typically don't export anything. We should remove >>> the export setti

Re: cleaning up PostgresNode.pm

2021-06-30 Thread Andrew Dunstan
On 6/30/21 8:30 AM, Alvaro Herrera wrote: > On 2021-Jun-30, Andrew Dunstan wrote: > >> On 6/30/21 12:35 AM, Michael Paquier wrote: >>> On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote: >>> skip_equals is not used. The only caller of adjust_conf is >>> PostgresNode itself. >> Well,

Re: cleaning up PostgresNode.pm

2021-06-30 Thread Alvaro Herrera
On 2021-Jun-30, Andrew Dunstan wrote: > On 6/30/21 12:35 AM, Michael Paquier wrote: > > On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote: > > skip_equals is not used. The only caller of adjust_conf is > > PostgresNode itself. > > Well, nothing is using it right now :-) It's intend

Re: cleaning up PostgresNode.pm

2021-06-30 Thread Andrew Dunstan
On 6/30/21 12:35 AM, Michael Paquier wrote: > On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote: >> Patch 1 adds back the '-w' flag to pg_ctl in the start() method. It's >> redundant on modern versions of Postgres but it's harmless, and helps >> with subclassing for older versions wh

Re: cleaning up PostgresNode.pm

2021-06-29 Thread Michael Paquier
On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote: > Patch 1 adds back the '-w' flag to pg_ctl in the start() method. It's > redundant on modern versions of Postgres but it's harmless, and helps > with subclassing for older versions where it wasn't the default. 05cd12e applied to all

Re: cleaning up PostgresNode.pm

2021-06-28 Thread Andrew Dunstan
On 4/24/21 3:14 PM, Alvaro Herrera wrote: > On 2021-Apr-24, Andrew Dunstan wrote: > >> I would like to undertake some housekeeping on PostgresNode.pm. >> >> 1. OO modules in perl typically don't export anything. We should remove >> the export settings. That would mean that clients would have to ca

Re: cleaning up PostgresNode.pm

2021-04-24 Thread Alvaro Herrera
On 2021-Apr-24, Andrew Dunstan wrote: > > I would like to undertake some housekeeping on PostgresNode.pm. > > 1. OO modules in perl typically don't export anything. We should remove > the export settings. That would mean that clients would have to call > "PostgresNode->get_new_node()" (but see i

cleaning up PostgresNode.pm

2021-04-24 Thread Andrew Dunstan
I would like to undertake some housekeeping on PostgresNode.pm. 1. OO modules in perl typically don't export anything. We should remove the export settings. That would mean that clients would have to call "PostgresNode->get_new_node()" (but see item 2) and "PostgresNode::get_free_port()" instead