Re: clean up test_rls_hooks module

2022-03-23 Thread Andres Freund
Hi, On 2022-03-23 10:07:06 -0400, Tom Lane wrote: > Andrew Dunstan writes: > > Here's a patch to fix those things. > > Seems reasonable to me, except that I think I'd leave the formatting > of the OBJS macro alone. IIRC, Andres or someone went around and > made all of those follow this one-file

Re: clean up test_rls_hooks module

2022-03-23 Thread Tom Lane
Andrew Dunstan writes: > Here's a patch to fix those things. Seems reasonable to me, except that I think I'd leave the formatting of the OBJS macro alone. IIRC, Andres or someone went around and made all of those follow this one-file-per-line style some time ago. regards

clean up test_rls_hooks module

2022-03-23 Thread Andrew Dunstan
Over at [1] Mark Dilger got led astray because he used src/test/modules/test_rls_hooks as a template for his new test module. It looks like that module was created with some over eager copying of another test module, but it has a couple of things wrong with it. . it isn't an extension, so the Mak