Re: clarify "rewritten" in pg_checksums docs

2020-09-06 Thread Michael Paquier
On Wed, Sep 02, 2020 at 05:26:16PM +0900, Michael Paquier wrote: > Using rewritten still sounds more adapted to me, as we still write the > thing with chunks of size BLCKSZ. No objections with the addition of > "in-place" for that sentence. Any extra opinions? Seeing no objections, I have applie

Re: clarify "rewritten" in pg_checksums docs

2020-09-02 Thread Michael Paquier
On Tue, Sep 01, 2020 at 03:44:06PM +0200, Daniel Gustafsson wrote: > Well, I was thinking less technically accurate and more descriptive for end > users, hiding the implementation details. "Rewrite" sounds to me more like > changing data rather than amending pages with a checksum keeping data inta

Re: clarify "rewritten" in pg_checksums docs

2020-09-01 Thread Daniel Gustafsson
> On 1 Sep 2020, at 15:34, Michael Banck wrote: > Am Dienstag, den 01.09.2020, 15:29 +0200 schrieb Daniel Gustafsson: >> Isn't "modified in-place" a more accurate description of the process? > > AIUI we do rewrite the whole file (block by block, after updating the > page header with the checksum

Re: clarify "rewritten" in pg_checksums docs

2020-09-01 Thread Michael Banck
Hi, Am Dienstag, den 01.09.2020, 15:29 +0200 schrieb Daniel Gustafsson: > > On 1 Sep 2020, at 15:13, Michael Banck wrote: > > the pg_checksums docs mention that "When enabling checksums, every file > > in the cluster is rewritten". > > > > From IRC discussions, "rewritten" seems ambiguous, it co

Re: clarify "rewritten" in pg_checksums docs

2020-09-01 Thread Daniel Gustafsson
> On 1 Sep 2020, at 15:13, Michael Banck wrote: > the pg_checksums docs mention that "When enabling checksums, every file > in the cluster is rewritten". > > From IRC discussions, "rewritten" seems ambiguous, it could mean that a > second copy of the file is written and then switched over, imply

clarify "rewritten" in pg_checksums docs

2020-09-01 Thread Michael Banck
Hi, the pg_checksums docs mention that "When enabling checksums, every file in the cluster is rewritten". >From IRC discussions, "rewritten" seems ambiguous, it could mean that a second copy of the file is written and then switched over, implying increased storage demand during the operation. So