>
> I've applied this down to v16 now, thanks for the submission!
>
Thanks for pushing!
Masaki Kuwamura
> On 24 Sep 2023, at 10:22, Kuwamura Masaki
> wrote:
>
> LGTM too!
I've applied this down to v16 now, thanks for the submission!
--
Daniel Gustafsson
LGTM too!
>> a bit to make the diff smaller,
I couldn't think from that perspective. Thanks for your update, Daniel-san.
Masaki Kuwamura
On Fri, Sep 22, 2023 at 02:58:20PM +0200, Daniel Gustafsson wrote:
> I had a look at this and tweaked the testcase a bit to make the diff smaller,
> as well as removed the (in some cases) superfluous space in the generated SQL
> query mentioned upthread. The attached two patches is what I propose
> On 22 Sep 2023, at 11:08, Kuwamura Masaki
> wrote:
>
> No worries at all. If you look at the page now you will see all green
> checkmarks indicating that the patch was tested in CI. So now we know that
> your tests fail without the fix and work with the fix applied, so all is well.
>
> Than
>
> No worries at all. If you look at the page now you will see all green
> checkmarks indicating that the patch was tested in CI. So now we know that
> your tests fail without the fix and work with the fix applied, so all is
> well.
>
Thank you for your kind words!
And it seems to me that all
> On 21 Sep 2023, at 03:53, Kuwamura Masaki
> wrote:
> When sending an update, please include the previous patch as well with your
> new
> tests as a 0002 patch in a patchset. The CFBot can only apply and build/test
> patches when the entire patchset is attached to the email. The below
> test
>
> I agree. Supporting pattern matching should, if anyone is interested in
> trying, be done separately in its own thread, no need to move the goalposts
> here. Sorry if I made it sound like so upthread.
>
I got it.
> When sending an update, please include the previous patch as well with
> you
> On 20 Sep 2023, at 11:46, Kuwamura Masaki
> wrote:
> I think that supporting pattern matching is quite nice.
> But it will be not only tough but also a breaking change, I wonder.
> So I guess this change should be commited either way.
I agree. Supporting pattern matching should, if anyone is
Thank you for all your reviews!
>>> PATTERN should be changed to SCHEMA because -n and -N options don't
support
>>> pattern matching for schema names. The attached patch 0001 fixes this.
>>
>> True, there is no pattern matching performed. I wonder if it's worth
lifting
>> the pattern matching fro
On Fri, Sep 15, 2023 at 10:13:10AM +0200, Daniel Gustafsson wrote:
>> On 15 Sep 2023, at 04:39, Kyotaro Horiguchi wrote:
>> It seems to work fine. However, if we're aiming for consistent
>> spacing, the "IS NULL" (two spaces in between) might be an concern.
>
> I don't think that's a problem. I
> On 15 Sep 2023, at 04:39, Kyotaro Horiguchi wrote:
> At Thu, 14 Sep 2023 07:57:57 -0700, Nathan Bossart
> wrote in
>> Yeah, I think we can fix the JOIN as you suggest. I quickly put a patch
>> together to demonstrate.
Looks good from a quick skim.
>> We should probably add some tests...
At Thu, 14 Sep 2023 07:57:57 -0700, Nathan Bossart
wrote in
> On Thu, Sep 14, 2023 at 02:06:51PM +0200, Daniel Gustafsson wrote:
> > I can reproduce that, a single -N works but adding multiple -N's makes none
> > of
> > them excluded. The current coding does this:
> >
> > if (objfilter & O
On Thu, Sep 14, 2023 at 02:06:51PM +0200, Daniel Gustafsson wrote:
>> On 14 Sep 2023, at 13:21, Kuwamura Masaki
>> wrote:
>
>> PATTERN should be changed to SCHEMA because -n and -N options don't support
>> pattern matching for schema names. The attached patch 0001 fixes this.
>
> True, there i
> On 14 Sep 2023, at 13:21, Kuwamura Masaki
> wrote:
> PATTERN should be changed to SCHEMA because -n and -N options don't support
> pattern matching for schema names. The attached patch 0001 fixes this.
True, there is no pattern matching performed. I wonder if it's worth lifting
the pattern
Hi there,
I have 1 trivial fix, 1 bug fix, and 1 suggestion about vacuumdb.
First, I noticed that the help message of `vacuumdb` is a bit incorrect.
`vacuumdb -?` displays the following message
```
...
-n, --schema=PATTERNvacuum tables in the specified schema(s)
only
-N, --exclud
16 matches
Mail list logo
