Hi Amit, Rushabh,
On 2019-Jun-07, Amit Langote wrote:
> Thanks for adding the tests. Looks good.
Thanks Amit, pushed now. Marking open item as done.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Hi Alvaro,
On Fri, Jun 7, 2019 at 8:02 AM Alvaro Herrera wrote:
> On 2019-Jun-06, Alvaro Herrera wrote:
>
> > Here's my proposed patch. I changed/expanded the tests a little bit to
> > ensure more complete coverage.
>
> Well, revise the comments a little bit.
Thanks for adding the tests. Looks
On 2019-Jun-06, Alvaro Herrera wrote:
> Here's my proposed patch. I changed/expanded the tests a little bit to
> ensure more complete coverage.
Well, revise the comments a little bit.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA
On 2019-May-20, Alvaro Herrera wrote:
> On 2019-May-20, Amit Langote wrote:
>
> > Should we add this to open items?
>
> Yeah. I'm AFK this week, but can handle it afterwards. The fix already
> missed beta1, so I don't think there's a problem with taking a little
> bit longer.
Here's my propos
On 2019/05/21 11:29, Alvaro Herrera wrote:
> On 2019-May-20, Amit Langote wrote:
>
>> Should we add this to open items?
>
> Yeah. I'm AFK this week, but can handle it afterwards. The fix already
> missed beta1, so I don't think there's a problem with taking a little
> bit longer.
OK, added.
T
On 2019-May-20, Amit Langote wrote:
> Should we add this to open items?
Yeah. I'm AFK this week, but can handle it afterwards. The fix already
missed beta1, so I don't think there's a problem with taking a little
bit longer.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
Postgr
On 2019/05/20 13:42, Rushabh Lathia wrote:
> On Fri, May 17, 2019 at 10:30 AM Amit Langote
>> Why not change it like this instead:
>>
>> @@ -681,7 +681,8 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid
>> ownerId,
>> Assert(list_length(inheritOids) == 1);
>> tablespaceId =
On Fri, May 17, 2019 at 10:30 AM Amit Langote
wrote:
> Agree that this behavior change seems unintentional.
>
> On 2019/05/17 12:40, Rushabh Lathia wrote:
> > Looking at the commit changes, it seems like at condition when no other
> > tablespace is specified, we default the tablespace to the pare
On 2019/05/17 12:40, Rushabh Lathia wrote:
> Hi,
>
> Consider the below test:
>
> create tablespace mytbs location '/home/rushabh/mywork/workspace/pg/';
> create table test ( a int , b int ) partition by list (a);
>
> set default_tablespace to mytbs;
> create table test_p1 partition of test for
Agree that this behavior change seems unintentional.
On 2019/05/17 12:40, Rushabh Lathia wrote:
> Looking at the commit changes, it seems like at condition when no other
> tablespace is specified, we default the tablespace to the parent partitioned
> table's.
>
> else if (stmt->partbound)
>
Hi,
Consider the below test:
create tablespace mytbs location '/home/rushabh/mywork/workspace/pg/';
create table test ( a int , b int ) partition by list (a);
set default_tablespace to mytbs;
create table test_p1 partition of test for values in (1);
In the above test, after the setting the defa
11 matches
Mail list logo
