On Tue, Jun 01, 2021 at 10:14:49AM +0900, Michael Paquier wrote:
> Okay, applied this stuff to 12 and 13 to take care of the build
> failures with hamerkop. The ECPG tests should also turn back to green
> there.
hamerkop has reported back, and things are now good on those
branches. Now for the r
On Mon, May 31, 2021 at 09:14:36AM +0900, Michael Paquier wrote:
> I have been finally able to poke at that, resulting in the attached.
> You are right that adding only the fallback implementation for
> setenv() seems to be enough. I cannot get my environment to complain,
> and the code compiles.
On Sat, May 29, 2021 at 10:44:14AM -0400, Tom Lane wrote:
> What I had in mind was to *only* add pgwin32_setenv, not setenv.c.
> There's no evidence that any other modern platform lacks setenv.
> Moreover, there's no issue in these branches unless your platform
> lacks setenv yet has GSS support.
Michael Paquier writes:
> On Fri, May 28, 2021 at 11:37:22AM -0400, Tom Lane wrote:
>> It's not clear to me how much of 7ca37fb you're envisioning
>> back-patching in (2). I think it'd be best to back-patch
>> only the addition of pgwin32_setenv, and then let the gssapi
>> code use it. In that w
On Fri, May 28, 2021 at 11:37:22AM -0400, Tom Lane wrote:
> There's a lot of value in keeping the branches looking alike.
> On the other hand, 7ca37fb hasn't survived contact with the
> public yet, so I'm a bit nervous about it.
I don't think this set of complications is worth the risk
destabilizi
Michael Paquier writes:
> We can do two things here:
> 1) Switch be-secure-gssapi.c and auth.c to use putenv().
> 2) Backport into 12 and 13 the fallback implementation of setenv
> introduced in 7ca37fb, and keep be-secure-gssapi.c as they are now.
There's a lot of value in keeping the branches l
Hi all,
Now that hamerkop has been fixed and that we have some coverage with
builds of GSSAPI on Windows thanks to 02511066, the buildfarm has been
complaining about a build failure on Windows for 12 and 13:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=hamerkop&dt=2021-05-28%2011%
