On Sat, Jun 08, 2019 at 10:24:39AM +0900, Michael Paquier wrote:
> Indeed, this makes the header more consistent. Thanks for noticing.
Double-checked the surroundings, and done.
--
Michael
signature.asc
Description: PGP signature
On Fri, Jun 07, 2019 at 09:52:26AM +0200, Daniel Gustafsson wrote:
> While looking at libpq.h I noticed what seems to be a few nitpicks: the GSS
> function prototype isn’t using the common format of having a comment
> specifying
> the file it belongs to; ssl_loaded_verify_locations is defined as e
On Fri, Jun 07, 2019 at 08:11:07AM -0400, Stephen Frost wrote:
> I'm pretty sure it ended up there just because that's how things are in
> src/interfaces/libpq. I don't have any objection to moving it, I had
> really just been waiting to see where that thread ended up going.
>
> On a quick look,
Greetings,
* Michael Paquier (mich...@paquier.xyz) wrote:
> As mentioned on another thread about test coverage, I have noticed
> that be-gssapi-common.h is not placed at the correct location, even
> its its identication path at the top points to where the file should
> be:
> https://www.postgresql
> On 7 Jun 2019, at 06:34, Michael Paquier wrote:
> Any objections to something like the attached?
No objections to moving the file per the patch.
While looking at libpq.h I noticed what seems to be a few nitpicks: the GSS
function prototype isn’t using the common format of having a comment spe
Hi all,
As mentioned on another thread about test coverage, I have noticed
that be-gssapi-common.h is not placed at the correct location, even
its its identication path at the top points to where the file should
be:
https://www.postgresql.org/message-id/20190604014630.gh1...@paquier.xyz
The file
