Re: bad logging around broken restore_command

2020-11-19 Thread Fujii Masao
On 2020/11/19 20:27, Pavel Borisov wrote: The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested I decided to add my re

Re: bad logging around broken restore_command

2020-11-19 Thread Pavel Borisov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested I decided to add my review to this simple patch. I applied Fuji's pat

Re: bad logging around broken restore_command

2020-03-24 Thread Fujii Masao
On 2020/03/10 11:47, Kyotaro Horiguchi wrote: At Thu, 6 Feb 2020 23:23:42 +0900, Fujii Masao wrote in On 2020/02/06 1:10, Jeff Janes wrote: If the restore command claims to have succeeded, but fails to have created a file with the right name (due to typos or escaping or quoting issues, for

Re: bad logging around broken restore_command

2020-03-09 Thread Kyotaro Horiguchi
At Thu, 6 Feb 2020 23:23:42 +0900, Fujii Masao wrote in > On 2020/02/06 1:10, Jeff Janes wrote: > > If the restore command claims to have succeeded, but fails to have created > > a file with the right name (due to typos or escaping or quoting issues, for > > example), no complaint is issued at t

Re: bad logging around broken restore_command

2020-03-09 Thread David Steele
Hi Jeff, On 2/6/20 9:23 AM, Fujii Masao wrote: I've attached a patch which emits a LOG message for ENOENT. Isn't it better to use "could not stat file" message even in ENOENT case? If yes, something like message that you used in the patch should be logged as DETAIL or HINT message. So, what

Re: bad logging around broken restore_command

2020-02-06 Thread Fujii Masao
On 2020/02/06 1:10, Jeff Janes wrote: If the restore command claims to have succeeded, but fails to have created a file with the right name (due to typos or escaping or quoting issues, for example), no complaint is issued at the time, and it then fails later with a relatively uninformative er

bad logging around broken restore_command

2020-02-05 Thread Jeff Janes
If the restore command claims to have succeeded, but fails to have created a file with the right name (due to typos or escaping or quoting issues, for example), no complaint is issued at the time, and it then fails later with a relatively uninformative error message like "could not locate required