Re: backend/nodes cleanup: Move loop variables definitions into for statement

On 25.11.25 04:46, Chao Li wrote: On Tue, Nov 25, 2025 at 7:38 AM Chao Li > wrote: On Mon, Nov 24, 2025 at 11:00 PM Peter Eisentraut mailto:[email protected]>> wrote: On 19.11.25 11:32, Chao Li wrote: > On Wed, Nov 19, 2025 at 5:36 P

Re: backend/nodes cleanup: Move loop variables definitions into for statement

On Tue, Nov 25, 2025 at 7:38 AM Chao Li wrote: > > On Mon, Nov 24, 2025 at 11:00 PM Peter Eisentraut > wrote: > >> On 19.11.25 11:32, Chao Li wrote: >> > On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut > > > wrote: >> > >> > >> > >> > In a couple of cases, you a

Re: backend/nodes cleanup: Move loop variables definitions into for statement

On Mon, Nov 24, 2025 at 11:00 PM Peter Eisentraut wrote: > On 19.11.25 11:32, Chao Li wrote: > > On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut > > wrote: > > > > > > > > In a couple of cases, you are changing the type of the loop variable > > from Size to

Re: backend/nodes cleanup: Move loop variables definitions into for statement

On 19.11.25 11:32, Chao Li wrote: On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut > wrote: In a couple of cases, you are changing the type of the loop variable from Size to int.  I would not expect such a change in a patch of this nature.  If you have

Re: backend/nodes cleanup: Move loop variables definitions into for statement

On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut wrote: > > > In a couple of cases, you are changing the type of the loop variable > from Size to int. I would not expect such a change in a patch of this > nature. If you have a reason to change it, please explain it (but I > doubt the change is

Re: backend/nodes cleanup: Move loop variables definitions into for statement

On 12.11.25 09:00, Chao Li wrote: While working on the other patch [1] that touched tbm_add_tuples() under src/backend/nodes, I moved a loop variable into for statement by the way as I knew Peter Eisentraut had done some efforts about that, see [2]. However, Peter removed that change from the

Re: backend/nodes cleanup: Move loop variables definitions into for statement

Added to CF: https://commitfest.postgresql.org/patch/6227/ > On Nov 14, 2025, at 21:52, Chao Li wrote: > > > > On Wed, Nov 12, 2025 at 4:00 PM Chao Li wrote: > Hi Hackers, > > While working on the other patch [1] that touched tbm_add_tuples() under > src/backend/nodes, I moved a loop variab

Re: backend/nodes cleanup: Move loop variables definitions into for statement

On Wed, Nov 12, 2025 at 4:00 PM Chao Li wrote: > Hi Hackers, > > While working on the other patch [1] that touched tbm_add_tuples() under > src/backend/nodes, I moved a loop variable into for statement by the way as > I knew Peter Eisentraut had done some efforts about that, see [2]. > > However,

backend/nodes cleanup: Move loop variables definitions into for statement

Hi Hackers, While working on the other patch [1] that touched tbm_add_tuples() under src/backend/nodes, I moved a loop variable into for statement by the way as I knew Peter Eisentraut had done some efforts about that, see [2]. However, Peter removed that change from the patch and he said that sh