On 06/15/2018 12:21 AM, Peter Eisentraut wrote:
On 6/11/18 16:06, Andrew Dunstan wrote:
This affects pretty much nothing. In fact some of the other changes I've
recently committed were arguably more dangerous. Do you want me to
revert the whole lot?
No, but this whole let's clean up the Perl
On 6/11/18 16:06, Andrew Dunstan wrote:
> This affects pretty much nothing. In fact some of the other changes I've
> recently committed were arguably more dangerous. Do you want me to
> revert the whole lot?
No, but this whole let's clean up the Perl code initiative seemed to
have come out of no
On 06/11/2018 03:38 PM, Andrew Dunstan wrote:
On 06/11/2018 02:33 PM, Alvaro Herrera wrote:
On 2018-Jun-05, Daniel Gustafsson wrote:
On 5 Jun 2018, at 16:31, Andrew Dunstan
wrote:
The patch contains a simple script to run the checks. The code that
finds perl files is put in a function i
Andrew Dunstan writes:
> On 06/11/2018 04:01 PM, Peter Eisentraut wrote:
>> Why is this being committed after feature freeze?
> This affects pretty much nothing. In fact some of the other changes I've
> recently committed were arguably more dangerous. Do you want me to
> revert the whole lot?
On 06/11/2018 04:01 PM, Peter Eisentraut wrote:
On 6/11/18 15:38, Andrew Dunstan wrote:
On 5 Jun 2018, at 16:31, Andrew Dunstan wrote:
The patch contains a simple script to run the checks. The code that finds perl
files is put in a function in a single file that is sourced by the three
loc
On 6/11/18 15:38, Andrew Dunstan wrote:
On 5 Jun 2018, at 16:31, Andrew Dunstan
wrote:
The patch contains a simple script to run the checks. The code that finds
perl files is put in a function in a single file that is sourced by the
three locations that need it.
>>> +1
On 06/11/2018 02:33 PM, Alvaro Herrera wrote:
On 2018-Jun-05, Daniel Gustafsson wrote:
On 5 Jun 2018, at 16:31, Andrew Dunstan wrote:
The patch contains a simple script to run the checks. The code that finds perl
files is put in a function in a single file that is sourced by the three
loc
On 2018-Jun-05, Daniel Gustafsson wrote:
> > On 5 Jun 2018, at 16:31, Andrew Dunstan
> > wrote:
>
> > The patch contains a simple script to run the checks. The code that finds
> > perl files is put in a function in a single file that is sourced by the
> > three locations that need it.
>
> +1
On 06/05/2018 05:14 PM, Daniel Gustafsson wrote:
This comment should say “perlcheck/..” and not “pgperlcritic/.." I assume:
Thanks. will fix.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
> On 5 Jun 2018, at 16:31, Andrew Dunstan
> wrote:
> The patch contains a simple script to run the checks. The code that finds
> perl files is put in a function in a single file that is sourced by the three
> locations that need it.
+1 on centralizing the find-files function.
> The directory
Here is a follow up patch to last weeks commit allowing all perl files
to be checked clean for compile time errors and warnings.
The patch contains a simple script to run the checks. The code that
finds perl files is put in a function in a single file that is sourced
by the three locations
11 matches
Mail list logo
