Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-21 Thread Peter Eisentraut
On 2020-02-21 21:25, Tom Lane wrote: Peter Eisentraut writes: committed crake says that this doesn't pass perlcritic. OK, fixed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-21 Thread Tom Lane
Peter Eisentraut writes: > committed crake says that this doesn't pass perlcritic. regards, tom lane

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-21 Thread Peter Eisentraut
On 2020-02-21 05:00, Michael Paquier wrote: On Thu, Feb 20, 2020 at 09:31:32AM -0500, Tom Lane wrote: Peter Eisentraut writes: The main benefit is that if you make "blind" edits in the Perl files, you can verify them easily, first by seeing that the Perl code runs, second, depending on the cir

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-20 Thread Michael Paquier
On Thu, Feb 20, 2020 at 09:31:32AM -0500, Tom Lane wrote: > Peter Eisentraut writes: >> The main benefit is that if you make "blind" edits in the Perl files, >> you can verify them easily, first by seeing that the Perl code runs, >> second, depending on the circumstances, by diffing the created

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-20 Thread Tom Lane
Peter Eisentraut writes: > On 2020-02-13 16:36, Tom Lane wrote: >> Yeah, I'm wondering exactly how this helps. IME the typical sort of >> breakage is "the MSVC build doesn't know that file X needs to be >> included when building Y". It seems like just building the project >> files will teach one

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-20 Thread Peter Eisentraut
On 2020-02-13 16:36, Tom Lane wrote: Julien Rouhaud writes: On Thu, Feb 13, 2020 at 02:24:43PM +0100, Peter Eisentraut wrote: When making build system changes that risk breaking the MSVC build system, it's useful to be able to run the part of the MSVC build tools that read the makefiles and pr

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-13 Thread Tom Lane
Julien Rouhaud writes: > On Thu, Feb 13, 2020 at 02:24:43PM +0100, Peter Eisentraut wrote: >>> When making build system changes that risk breaking the MSVC build system, >>> it's useful to be able to run the part of the MSVC build tools that read the >>> makefiles and produce the project files und

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-13 Thread Julien Rouhaud
On Thu, Feb 13, 2020 at 02:24:43PM +0100, Peter Eisentraut wrote: > On 2020-02-13 13:04, Michael Paquier wrote: > > On Thu, Feb 13, 2020 at 12:00:54PM +0100, Peter Eisentraut wrote: > > > When making build system changes that risk breaking the MSVC build system, > > > it's useful to be able to run

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-13 Thread Peter Eisentraut
On 2020-02-13 13:04, Michael Paquier wrote: On Thu, Feb 13, 2020 at 12:00:54PM +0100, Peter Eisentraut wrote: When making build system changes that risk breaking the MSVC build system, it's useful to be able to run the part of the MSVC build tools that read the makefiles and produce the project

Re: allow running parts of src/tools/msvc/ under not Windows

2020-02-13 Thread Michael Paquier
On Thu, Feb 13, 2020 at 12:00:54PM +0100, Peter Eisentraut wrote: > When making build system changes that risk breaking the MSVC build system, > it's useful to be able to run the part of the MSVC build tools that read the > makefiles and produce the project files under a not-Windows platform. This

allow running parts of src/tools/msvc/ under not Windows

2020-02-13 Thread Peter Eisentraut
When making build system changes that risk breaking the MSVC build system, it's useful to be able to run the part of the MSVC build tools that read the makefiles and produce the project files under a not-Windows platform. This part does not really depend on anything particular to Windows, so i