Re: add missing PQfinish() calls to vacuumdb

2025-02-04 Thread Michael Paquier
On Tue, Feb 04, 2025 at 10:30:58AM -0600, Nathan Bossart wrote: > I noticed that vacuum_one_database() doesn't call PQfinish() before > pg_fatal() in a few of the server version checks. I seem to have > unintentionally established this precedent in commit 00d1e88. Michael > claimed to have fixed

Re: add missing PQfinish() calls to vacuumdb

2025-02-04 Thread Nathan Bossart
On Tue, Feb 04, 2025 at 05:51:28PM +0100, Daniel Gustafsson wrote: > No objections, I too prefer to do the right thing here. +1 on backpatching. Committed. Thanks for looking. -- nathan

Re: add missing PQfinish() calls to vacuumdb

2025-02-04 Thread Daniel Gustafsson
> On 4 Feb 2025, at 17:30, Nathan Bossart wrote: > > I noticed that vacuum_one_database() doesn't call PQfinish() before > pg_fatal() in a few of the server version checks. I seem to have > unintentionally established this precedent in commit 00d1e88. Michael > claimed to have fixed it before c

add missing PQfinish() calls to vacuumdb

2025-02-04 Thread Nathan Bossart
I noticed that vacuum_one_database() doesn't call PQfinish() before pg_fatal() in a few of the server version checks. I seem to have unintentionally established this precedent in commit 00d1e88. Michael claimed to have fixed it before committing [0], but that seems to have been missed, too. I do