Re: about allow_system_table_mods and SET STATISTICS

2019-12-11 Thread Peter Eisentraut
On 2019-12-10 17:23, Tom Lane wrote: Peter Eisentraut writes: Good point. Done in the attached patch. (If someone wanted to revive the original functionality, it would nowadays probably be easier to add a flag ATT_SYSTEM_TABLE to ATSimplePermissions(), so there is really no reason to keep the

Re: about allow_system_table_mods and SET STATISTICS

2019-12-10 Thread Tom Lane
Peter Eisentraut writes: > Good point. Done in the attached patch. > (If someone wanted to revive the original functionality, it would > nowadays probably be easier to add a flag ATT_SYSTEM_TABLE to > ATSimplePermissions(), so there is really no reason to keep the old > function separate.) Ye

Re: about allow_system_table_mods and SET STATISTICS

2019-12-10 Thread Peter Eisentraut
On 2019-12-05 00:16, Tom Lane wrote: Seems reasonable. The argument for making this an exception to allow_system_table_mods was always more about expediency than logical cleanliness. After the recent changes I think it's okay to remove the special case (especially since nobody has griped about

Re: about allow_system_table_mods and SET STATISTICS

2019-12-04 Thread Tom Lane
Peter Eisentraut writes: > Until PostgreSQL 9.1, it was possible to run ALTER TABLE ... SET > STATISTICS without allow_system_table_mods. In PostgreSQL 9.2 and > later, this no longer works. This change was apparently accidental. (I > gave up after a while trying to bisect it exactly, but pr

about allow_system_table_mods and SET STATISTICS

2019-12-04 Thread Peter Eisentraut
Until PostgreSQL 9.1, it was possible to run ALTER TABLE ... SET STATISTICS without allow_system_table_mods. In PostgreSQL 9.2 and later, this no longer works. This change was apparently accidental. (I gave up after a while trying to bisect it exactly, but probably something related to 1489e