On Fri, Feb 21, 2025 at 5:09 PM Robert Haas wrote:
>
> On Fri, Feb 21, 2025 at 7:04 PM Tom Lane wrote:
> > A very significant fraction of the buildfarm is now pink.
> > If you don't have a fix pretty nearly ready, please revert.
>
> When we're going to do a r
Hi,
Regarding the patch push, I am not a committer, but perhaps my
perspective might be interesting. When I noticed late on Friday evening
that the tests had failed, I was quite anxious about the situation,
thinking I would need to fix it right away. However, Robert committed
the fix before t
This was very painful to read. +1 on making changes. Both for a
culture change to require less urgency over the weekend if it's a
minor failure, and probably also a tooling change to make this less of
a problem in general.
On Sat, 22 Feb 2025 at 04:38, Robert Haas wrote:
>
> On Fri, Feb 21, 2025
On Fri, Feb 21, 2025 at 9:14 PM Andres Freund wrote:
> I'd also say that breaking CI and BF is probably something I'd consider more
> urgent, as that could indicate the commit was just generally less well tested.
This is possible, but I think we oversell it by quite a lot. It's
quite possible for
Hi,
On 2025-02-21 20:09:24 -0500, Robert Haas wrote:
> In the case of my commit today, the failures are the result of a
> 2-line regression diff with no functional impact that neither CI nor
> any of the 11 reviewers noticed. That just shouldn't be the sort of
> thing that results in somebody havi
On Fri, Feb 21, 2025 at 7:04 PM Tom Lane wrote:
> A very significant fraction of the buildfarm is now pink.
> If you don't have a fix pretty nearly ready, please revert.
When we're going to do a release, you want no commits for at least 24
hours before the release so that we c
