Re: Yet another way for pg_ctl stop to fail on Windows

2024-09-08 Thread Noah Misch
On Sun, Sep 08, 2024 at 06:00:00PM +0300, Alexander Lakhin wrote: > 07.09.2024 21:11, Noah Misch wrote: > > > Noah, what do you think of handling this error in line with handling of > > > ERROR_BROKEN_PIPE and ERROR_BAD_PIPE (which was done in 0ea1f2a3a)? > > > > > > I tried the following change:

Re: Yet another way for pg_ctl stop to fail on Windows

2024-09-08 Thread Alexander Lakhin
07.09.2024 21:11, Noah Misch wrote: Noah, what do you think of handling this error in line with handling of ERROR_BROKEN_PIPE and ERROR_BAD_PIPE (which was done in 0ea1f2a3a)? I tried the following change:     switch (GetLastError())     {     case ERROR_BROKEN_PIPE:  

Re: Yet another way for pg_ctl stop to fail on Windows

2024-09-07 Thread Noah Misch
On Sat, Sep 07, 2024 at 03:00:00PM +0300, Alexander Lakhin wrote: > With extra logging added, I got: > ### Stopping node "CIC_2PC_test" using mode fast > # Running: pg_ctl -D > C:\src\postgresql\build/testrun/amcheck_3/003_cic_2pc\data/t_003_cic_2pc_CIC_2PC_test_data/pgdata > -m fast stop > waitin

Yet another way for pg_ctl stop to fail on Windows

2024-09-07 Thread Alexander Lakhin
Hello hackers, While trying to reproduce a recent fairywren (a Windows animal) failure, I ran amcheck/amcheck/003_cic_2pc in parallel inside a slowed-down VM and came across another issue: ### Stopping node "CIC_2PC_test" using mode fast # Running: pg_ctl -D C:\src\postgresql\build/testrun/amchec