Re: Yet another (minor) fix in BRIN

2020-11-08 Thread Tomas Vondra
On 11/8/20 12:34 PM, Michael Paquier wrote: > On Sat, Nov 07, 2020 at 10:45:26PM -0500, Tom Lane wrote: >> The weekend before stable-branch releases is probably not the best >> time to be pushing "minor" fixes into those branches. I got my >> fingers burned today, and so did Peter. Don't follow o

Re: Yet another (minor) fix in BRIN

2020-11-08 Thread Michael Paquier
On Sat, Nov 07, 2020 at 10:45:26PM -0500, Tom Lane wrote: > The weekend before stable-branch releases is probably not the best > time to be pushing "minor" fixes into those branches. I got my > fingers burned today, and so did Peter. Don't follow our example ;-) You could just apply your stuff a

Re: Yet another (minor) fix in BRIN

2020-11-07 Thread Tom Lane
Alvaro Herrera writes: > On 2020-Nov-08, Tomas Vondra wrote: >> While rebasing some of the BRIN patches, I noticed some of the code in >> brin_memtuple_initialize is duplicated. This happened in 8bf74967dab >> which moved some of the code from brin_new_memtuple, not removing the >> shared pieces.

Re: Yet another (minor) fix in BRIN

2020-11-07 Thread Alvaro Herrera
On 2020-Nov-08, Tomas Vondra wrote: > While rebasing some of the BRIN patches, I noticed some of the code in > brin_memtuple_initialize is duplicated. This happened in 8bf74967dab > which moved some of the code from brin_new_memtuple, not removing the > shared pieces. In practice this is benign, o

Yet another (minor) fix in BRIN

2020-11-07 Thread Tomas Vondra
Hi, While rebasing some of the BRIN patches, I noticed some of the code in brin_memtuple_initialize is duplicated. This happened in 8bf74967dab which moved some of the code from brin_new_memtuple, not removing the shared pieces. In practice this is benign, of course. Barring objections I'll get t