Re: Remove XLogRecGetFullXid() in xlogreader.c?

2025-01-17 Thread Michael Paquier
On Fri, Jan 17, 2025 at 10:45:28AM -0500, Andres Freund wrote: > I think it is sensible infrastructure and we'll eventually end up using > it. The cost of having it fairly low. If it were a legacy thing that we > shouldn't introduce new users for it'd be a different story, but it's the > opposite.

Re: Remove XLogRecGetFullXid() in xlogreader.c?

2025-01-17 Thread Andres Freund
Hi, On 2025-01-17 14:00:49 +0900, Michael Paquier wrote: > XLogRecGetFullXid() has been introduced in 67b9b3ca3283 back in 2019, > but as far as I can see this has never been used in the code and this > is used nowhere in the core code. > > I have looked at Debian's codesearc

Re: Remove XLogRecGetFullXid() in xlogreader.c?

2025-01-17 Thread Nathan Bossart
(I've added Thomas Munro to the thread.) On Fri, Jan 17, 2025 at 02:00:49PM +0900, Michael Paquier wrote: > XLogRecGetFullXid() has been introduced in 67b9b3ca3283 back in 2019, > but as far as I can see this has never been used in the code and this > is used nowhere in the core cod

Remove XLogRecGetFullXid() in xlogreader.c?

2025-01-16 Thread Michael Paquier
Hi all, XLogRecGetFullXid() has been introduced in 67b9b3ca3283 back in 2019, but as far as I can see this has never been used in the code and this is used nowhere in the core code. I have looked at Debian's codesearch and also looked at traces of it on github without seeing it being

Re: XLogRecGetFullXid()

2019-07-14 Thread Thomas Munro
On Fri, Jul 12, 2019 at 1:25 PM Thomas Munro wrote: > Here is a small patch extracted from the undo log patch set that I'd > like to discuss separately and commit soon. [...] Pushed. -- Thomas Munro https://enterprisedb.com

XLogRecGetFullXid()

2019-07-11 Thread Thomas Munro
il.com -- Thomas Munro https://enterprisedb.com 0001-Add-XLogRecGetFullXid-function.patch Description: Binary data